Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3108535ybb; Mon, 6 Apr 2020 02:11:37 -0700 (PDT) X-Google-Smtp-Source: APiQypLgsxaa9oR68+hSXrBM543hv674Gx5VbBx/Uxuw1EslruRJ4Lq2GuSpAd7hPDD/mKYXbXDs X-Received: by 2002:a9d:775a:: with SMTP id t26mr16471305otl.178.1586164297340; Mon, 06 Apr 2020 02:11:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586164297; cv=none; d=google.com; s=arc-20160816; b=m3R0EZPMeTK64AKSNu9bxvtBsR3dO6EC3dySs0KUQGKu/pS+eOvgFcQ/vIin40nEPU 770VoZm4wRYiOdYH4HMj0Z3xK+8W8Nux8yT54SEWiKh//JMCpPVPDphbuZx0gG9SHZZ+ G+uF1tuWfSYjTdkxg+cbw5kBSAz1UNr3y73kNcVYpLGOjGRRj/h5VI2qym0Q/gshOs3O Cv3AYfVWIhTOmG7CRKymRufCu9SIv6vZG3TNKvbWuIxyn4QtuwjxKzDtz/LZq7ZqkyWb vPR5Sdg6+CpRY6zOX+OsR0R/Bc9gWtsYKX9/BbJjNZ1d1yQapeGCeIIt68gYs5PjDUN+ UcSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=bX417MiZkYFssTXSPCuNaM1zXe7dFdDsofnV8wO8ceM=; b=ffWDolg0n+jmopkYGVZpr3GqcOHM7hVseSMI21DgWZZP4Xvgf1skK6MqSJge3BftKo fWQSuBs41A6+PM4M44jSH6OJCrV+szCdtThVluWsRGMAeh7QRipZMSTi2MyBqfYzoWig 8HeC7d5pxmVXr9nPdf9kKm9VzbyWNJCNq0ANRpzmDcxflSeBlCxidfpQal8PHLOWyaWH gpNAQRAiU2rKATqJ9mAvZb4Bwzcm5cwKONb6s6Q+5y7aVhdYMAVp8z7jEu5/SRDrxpvz 0wUIVVwfVLb7vO++mczkIQuMhlyfJHYU7TlZcMbyNwy2nGExsp7gNszRn+4OWtWyc1ci HBLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n6si4696178otf.43.2020.04.06.02.11.23; Mon, 06 Apr 2020 02:11:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726860AbgDFJLF (ORCPT + 99 others); Mon, 6 Apr 2020 05:11:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:36862 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726663AbgDFJLF (ORCPT ); Mon, 6 Apr 2020 05:11:05 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 16907AC7B; Mon, 6 Apr 2020 09:11:04 +0000 (UTC) Date: Mon, 6 Apr 2020 11:11:03 +0200 (CEST) From: Miroslav Benes To: Julien Thierry cc: linux-kernel@vger.kernel.org, jpoimboe@redhat.com, peterz@infradead.org Subject: Re: [PATCH] objtool: Fix off-by-one in symbol_by_offset() In-Reply-To: <20200403131730.32618-1-jthierry@redhat.com> Message-ID: References: <20200403131730.32618-1-jthierry@redhat.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 3 Apr 2020, Julien Thierry wrote: > Sometimes, WARN_FUNC() and other users of symbol_by_offset() will > associate the first instruction of a symbol with the symbol preceding > it. > This is because symbol->offset + symbol->len is already outside of the > symbol's range. > > Signed-off-by: Julien Thierry Reviewed-by: Miroslav Benes