Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: w0e4wFoyPMioJjZrg0tdDfu3tmw9jEE9+uGjpS54iO4BcQfUS0+I2FYHqPu2e5RNQmuDxZSXtK
 n2s9GhAWn1jw==
IronPort-SDR: pSYiNYwup2Dbn4l6x88zHtU0hG4sV0HcYYC+mcCzl6PpV+ybcezEKC5wLH8DMjahWoALGHKG1t
 0XGmDEM9OAjA==
Date:   Mon, 6 Apr 2020 17:54:15 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Pavel Machek <pavel@ucw.cz>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH][v3] PM / sleep: Add pm_debug_messages boot command
 control
Message-ID: <20200406095415.GA21720@chenyu-office.sh.intel.com>
References: <20200402075652.13289-1-yu.c.chen@intel.com>
 <CAJZ5v0j2W5MYJnb4hiDn0OgR1xJZwm4TxVm9o-iw+epXPTp82g@mail.gmail.com>
 <20200406091813.GG31120@duo.ucw.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200406091813.GG31120@duo.ucw.cz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Pavel,
thanks for review.
On Mon, Apr 06, 2020 at 11:18:13AM +0200, Pavel Machek wrote:
> Hi!
> 
> > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> > > index ed73df5f1369..3fb9cbee8d28 100644
> > > --- a/Documentation/admin-guide/kernel-parameters.txt
> > > +++ b/Documentation/admin-guide/kernel-parameters.txt
> > > @@ -3720,6 +3720,9 @@
> > >                         Override pmtimer IOPort with a hex value.
> > >                         e.g. pmtmr=0x508
> > >
> > > +       pm_debug_messages       [SUSPEND,KNL]
> > > +                       Enable suspend/resume debug messages during boot up.
> > > +
> > >         pnp.debug=1     [PNP]
> > >                         Enable PNP debug messages (depends on the
> > >                         CONFIG_PNP_DEBUG_MESSAGES option).  Change at run-time
> 
> > Applied (as 5.7-rc material) with modified subject and changelog,
>   thanks!
> 
> Please don't.
> 
> We have pnp.debug, i8042.debug, acpi.debug_*, lsm.debug... It makes
> sense to do pm.debug... we want to have some consistency.
> 
We also have initcall_debug. It looks like the 'dot' indicates
that it is a module(or driver) parameter, and have multiple options
for user to choose from, but it looks like this is not the case for
pm_debug_messages.

Thanks,
Chenyu
> Thanks,
> 									Pavel
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html