Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DE891C433BA
Subject: Re: [PATCH 2/3] iio: adc: Add PMIC7 ADC bindings
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     agross@kernel.org, bjorn.andersson@linaro.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        mka@chromium.org, linus.walleij@linaro.org, sboyd@codeaurora.org,
        Jonathan.Cameron@huawei.com, smohanad@codeaurora.org,
        kgunda@codeaurora.org, aghayal@codeaurora.org,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, linux-iio@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org
References: <1585064650-16235-1-git-send-email-jprakash@codeaurora.org>
 <1585064650-16235-3-git-send-email-jprakash@codeaurora.org>
 <20200328165410.7db48818@archlinux>
From:   Jishnu Prakash <jprakash@codeaurora.org>
Message-ID: <fe8056c5-9480-a9a3-9626-5ebab8031b08@codeaurora.org>
Date:   Mon, 6 Apr 2020 17:15:21 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <20200328165410.7db48818@archlinux>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jonathan,

On 3/28/2020 10:24 PM, Jonathan Cameron wrote:
> On Tue, 24 Mar 2020 21:14:09 +0530
> Jishnu Prakash <jprakash@codeaurora.org> wrote:
>
>> Add documentation for PMIC7 ADC peripheral. For PMIC7 ADC, all SW
>> communication to ADC goes through PMK8350, which communicates with
>> other PMICs through PBS.
>>
>> Signed-off-by: Jishnu Prakash <jprakash@codeaurora.org>
>> ---
>>   .../bindings/iio/adc/qcom,spmi-vadc.yaml           | 28 ++++++++++++++++------
>>   1 file changed, 21 insertions(+), 7 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
>> index 72db14c..20f010c 100644
>> --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
>> +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
>> @@ -13,7 +13,7 @@ maintainers:
>>   description: |
>>     SPMI PMIC voltage ADC (VADC) provides interface to clients to read
>>     voltage. The VADC is a 15-bit sigma-delta ADC.
>> -  SPMI PMIC5 voltage ADC (ADC) provides interface to clients to read
>> +  SPMI PMIC5/PMIC7 voltage ADC (ADC) provides interface to clients to read
>>     voltage. The VADC is a 16-bit sigma-delta ADC.
>>   
>>   properties:
>> @@ -23,6 +23,7 @@ properties:
>>         - qcom,spmi-adc5
>>         - qcom,spmi-adc-rev2
>>         - qcom,pms405-adc
>> +      - qcom,spmi-adc7
>>   
>>     reg:
>>       description: VADC base address in the SPMI PMIC register map
>> @@ -65,6 +66,8 @@ patternProperties:
>>           description: |
>>             ADC channel number.
>>             See include/dt-bindings/iio/qcom,spmi-vadc.h
>> +          For PMIC7 ADC, the channel numbers are specified separately per PMIC
>> +          in the PMIC-specific files in include/dt-bindings/iio/.
> That makes me thing we really should have separate compatibles.  The
> parts clearly have differences, even if we haven't needed to use them
> explicitly as yet.
I'm not sure what you mean by this. We have added a new compatible 
property "qcom,spmi-adc7" for PMIC7 ADC.
>
>>   
>>         label:
>>           description: |
>> @@ -72,7 +75,7 @@ patternProperties:
>>               For thermistor inputs connected to generic AMUX or GPIO inputs
>>               these can vary across platform for the same pins. Hence select
>>               the platform schematics name for this channel. It is required
>> -            for "qcom,spmi-adc5" and "qcom,spmi-adc-rev2".
>> +            for "qcom,spmi-adc5", "qcom,spmi-adc7" and "qcom,spmi-adc-rev2".
>>           allOf:
>>             - $ref: /schemas/types.yaml#/definitions/string
>>   
>>