Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Date:   Mon, 6 Apr 2020 09:59:15 -0300
To:     Andreas Gerstmayr <agerstmayr@redhat.com>
Cc:     Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
        Kim Phillips <kim.phillips@amd.com>,
        linux-perf-users@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        "Steven Rostedt (VMware)" <rostedt@goodmis.org>,
        Kan Liang <kan.liang@linux.intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf script report: fix segfault when using DWARF mode
Message-ID: <20200406125915.GQ9917@kernel.org>
References: <05e0d633-54b4-fb3b-3d08-8963271017ea@amd.com>
 <20200402125417.422232-1-agerstmayr@redhat.com>
 <6a098ce1-1981-dcff-ea62-af5fc07ec7fb@amd.com>
 <20200403124028.GA18559@kernel.org>
 <bf95c9f1-1970-fce4-c6f2-dc231730e7ab@redhat.com>
 <0a942366-c8dd-4767-ee84-fdc0024b035f@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0a942366-c8dd-4767-ee84-fdc0024b035f@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Mon, Apr 06, 2020 at 11:30:23AM +0200, Andreas Gerstmayr escreveu:
> On 03.04.20 15:16, Andreas Gerstmayr wrote:
> > On 03.04.20 14:40, Arnaldo Carvalho de Melo wrote:
> > > Em Thu, Apr 02, 2020 at 02:07:51PM -0500, Kim Phillips escreveu:
> > > > On 4/2/20 7:54 AM, Andreas Gerstmayr wrote:
> > > > > When running perf script report with a Python script and a callgraph in
> > > > > DWARF mode, intr_regs->regs can be 0 and therefore crashing
> > > > > the regs_map
> > > > > function.

> > > > > Added a check for this condition (same check as in
> > > > > builtin-script.c:595).

> > > > > Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

> > > > Tested-by: Kim Phillips <kim.phillips@amd.com>

> > > Thanks, added this to that patch.

> > Great, thanks!
 
> Ah, I thought you were referring to my initial flamegraph.py perf script.
> Is there anything I can do to get it merged?

I'll test it today, were there any Tested-by: or Reviewed-by: to that
flamegraph.py?

That is not yet a strict requirement for having patches accepted, but
help me a lot in dedicating time to test things that passed thru some
testing by other people,

Thanks,

- Arnaldo