Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Zi Yan <ziy@nvidia.com>
To:     "Kirill A. Shutemov" <kirill@shutemov.name>
CC:     <akpm@linux-foundation.org>,
        Andrea Arcangeli <aarcange@redhat.com>,
        "Yang Shi" <yang.shi@linux.alibaba.com>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCHv2 4/8] khugepaged: Drain LRU add pagevec after swapin
Date:   Mon, 6 Apr 2020 09:11:27 -0400
Message-ID: <592329FA-69D0-4801-A5DF-F9CC8A3FE305@nvidia.com>
In-Reply-To: <20200403112928.19742-5-kirill.shutemov@linux.intel.com>
References: <20200403112928.19742-1-kirill.shutemov@linux.intel.com>
 <20200403112928.19742-5-kirill.shutemov@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed;
        boundary="=_MailMate_C83B2B7B-6470-4A8C-8DF4-B63554AB4EDB_=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=_MailMate_C83B2B7B-6470-4A8C-8DF4-B63554AB4EDB_=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On 3 Apr 2020, at 7:29, Kirill A. Shutemov wrote:

> External email: Use caution opening links or attachments
>
>
> __collapse_huge_page_isolate() may fail due to extra pin in the LRU add=

> pagevec. It's petty common for swapin case: we swap in pages just to

s/petty/pretty

> fail due to the extra pin.
>
> Drain LRU add pagevec on sucessfull swapin.

s/sucessfull/successful

>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
>  mm/khugepaged.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index fdc10ffde1ca..57ff287caf6b 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -940,6 +940,11 @@ static bool __collapse_huge_page_swapin(struct mm_=
struct *mm,
>         }
>         vmf.pte--;
>         pte_unmap(vmf.pte);
> +
> +       /* Drain LRU add pagevec to remove extra pin on the swapped in =
pages */
> +       if (swapped_in)
> +               lru_add_drain();
> +
>         trace_mm_collapse_huge_page_swapin(mm, swapped_in, referenced, =
1);
>         return true;
>  }
> --
> 2.26.0


=E2=80=94
Best Regards,
Yan Zi

--=_MailMate_C83B2B7B-6470-4A8C-8DF4-B63554AB4EDB_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAl6LKn8PHHppeUBudmlk
aWEuY29tAAoJEJ2yUfNrYfqKKxYQAIDwUi/sWEd4E5TrOi0JeGwSlI9dP3EFZQPt
joKck2BSsIirc6FgoyDMhOmstJ422Qa44vbD1eODystiAPJr2Kiv8QPGeKWBfWP0
jt6cnItoFE03xHxXw6sTjrM2LVMpjowgb6jcoHzI11QCi6GLcVTxyYJrA2pFuBhJ
6+Ku8ur5IHsLm1SQv3e6kmvdbrRWLyAe898CtGOuqJz7S1/sC69lK1lkc0PLGwDP
XhMxxwcgVnVMG5zouRHnGkMZ/GnIvxvkgcGe4EXVGTQXpB3Whbgw4wtzEOl3SHW9
RmRxNGREx3R5mfUwzidrPRjFPPKGMCkmNHwjawVYyViENPuH+uMZsx1p7TtrcefR
dFbUESbNowbd3r1DD0n1fbN/9QeMnTZTJorRNl7dZdYe5txB0AvBBhHSJCmcw84C
YyZ/wRpC9xv86FXuW4letu2H/J0zUJii/lQyanUWT1CorOzEi1nwRBm0iHQi2alM
0eCqxM5VyuEuhyfUAddlegZST1iL6ouVu4X2sZ6vUAXKtXgtggB0xFkyuDSw8J+e
a35pwnDJroqOFVImtZh+sfkq//ELFU4djvY+q2imm6pzoUgepCptAT29Mx9VbdOb
NgGl/SSSZ1GpayWTr0J27s+bBgadoseAV5BaB1dJzW3lFjZj5poRiSTSJ8EfY7Gf
Bz/36+gY
=q3D5
-----END PGP SIGNATURE-----

--=_MailMate_C83B2B7B-6470-4A8C-8DF4-B63554AB4EDB_=--