Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3340983ybb; Mon, 6 Apr 2020 07:07:23 -0700 (PDT) X-Google-Smtp-Source: APiQypIqHu4h5tbR2XOpIrrsd6XKtIKBCUx64PPX6YYgu111PLcH1X/hiIfJP+vZWPmv6gmOcSrv X-Received: by 2002:a9d:d36:: with SMTP id 51mr18318269oti.308.1586182042838; Mon, 06 Apr 2020 07:07:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586182042; cv=none; d=google.com; s=arc-20160816; b=c+C3KoV6YdszhlfYSOlabDRLpSY4pT3wpM7ZvSuKHlbtRmURcx/BsFoSIIo/ea4O0X mQDauvbYlHNgp+ZIy28mlPXIqHCHqnedIln8Es6XWpwlo71gCUdn93wBu0v8DWiGd4ZJ /XQUaDKzd53l0UeL9+S7kzJmqw+jAjkn0VwTbJ+y6v2hePUte6wfmJ4Y7fIuyhmrZBVC hJWfmvfQTRIxesdHd7OLHhnoBFay50HULf3Jg3Q8s9XlM6ZcmiKgHNQMURrkM4FMq3R5 vxIJ1h15fiSIolictzAqkRyK3nmkv+5qvqsvlDzaQzz4CkofySRUBKRQ4UJP15kRYkUI c41Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:in-reply-to:subject:cc:to:from :date:dkim-signature; bh=4Zai2PnScJLuvMSC9fbzk1WHAvNOiy2DIBUvYAKSs90=; b=wp/j2IrT4CIwIkSG3HkjF7rTjCn20AhqPCiqQza0t5hP71LAEtUw8iOca6gaqZqQis /YAvWWe1OdH7g0UG2ZzYqJJGd9KyxpJc6gVdypgg9/3q3zadcnYs87NvJoy89o1LTTKX va8dhNhbxsmYps6bMWTMDhGJPO6DjCQlFrzYJqN6f5mh0TmWMTILCx+4geSIjv96oDoW GjeBgl4OW7QPXOh+Rux5UAJN4vcvNObnxt/9211KfbN6xm+Ig/KPM9W9nA/Prauh3hGP 3xfGoXRSVtuViGLEF9f2LCcJ+cC3Ei0B9TD+WKKfmlSKkam/KORFPBfpgH1/M4NrfyBY IfSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=F8Wsfrq0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n198si7027934oig.37.2020.04.06.07.06.54; Mon, 06 Apr 2020 07:07:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=F8Wsfrq0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728593AbgDFODu (ORCPT + 99 others); Mon, 6 Apr 2020 10:03:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:60610 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728512AbgDFODu (ORCPT ); Mon, 6 Apr 2020 10:03:50 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F061C23433; Mon, 6 Apr 2020 14:03:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586181829; bh=UbkFYXsatuzQbUdxGVDQAxnHxupZla2aqzUmbNgnnGI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=F8Wsfrq0K11uyIa+GRybKbyBxjyoiQ72PIhjJXXAD60jFxbbOrC4Q4w3iv3l/BCOg lJlT3GYD87feNnOAUIEaPoSpOJQBWeGU4GmwpJPLNmpRQZAqKLlBlFIku2Bnqr6+Je TKQsB7z6IBrmoerd2HKKbinAfmIEktdHGKNMqioo= Date: Mon, 06 Apr 2020 15:03:46 +0100 From: Mark Brown To: Julia Lawall Cc: Alexandre Torgue , alsa-devel@alsa-project.org, Arnaud Pouliquen , kernel-janitors@vger.kernel.org, Liam Girdwood , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Mark Brown , Maxime Coquelin , Olivier Moysan , Takashi Iwai Subject: Applied "ASoC: stm32: sai: Add missing cleanup" to the asoc tree In-Reply-To: <1586099028-5104-1-git-send-email-Julia.Lawall@inria.fr> Message-Id: X-Patchwork-Hint: ignore Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: stm32: sai: Add missing cleanup has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 7506baeed8d05fc164254c64af14cfed2ac14446 Mon Sep 17 00:00:00 2001 From: Julia Lawall Date: Sun, 5 Apr 2020 17:03:48 +0200 Subject: [PATCH] ASoC: stm32: sai: Add missing cleanup The commit 0d6defc7e0e4 ("ASoC: stm32: sai: manage rebind issue") converts some function calls to their non-devm equivalents. The appropriate cleanup code was added to the remove function, but not to the probe function. Add a call to snd_dmaengine_pcm_unregister to compensate for the call to snd_dmaengine_pcm_register in case of subsequent failure. Fixes: commit 0d6defc7e0e4 ("ASoC: stm32: sai: manage rebind issue") Signed-off-by: Julia Lawall Acked-by: Olivier Moysan Link: https://lore.kernel.org/r/1586099028-5104-1-git-send-email-Julia.Lawall@inria.fr Signed-off-by: Mark Brown --- sound/soc/stm/stm32_sai_sub.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index 2bd280c01c33..0d0c9afd8791 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -1556,8 +1556,10 @@ static int stm32_sai_sub_probe(struct platform_device *pdev) ret = snd_soc_register_component(&pdev->dev, &stm32_component, &sai->cpu_dai_drv, 1); - if (ret) + if (ret) { + snd_dmaengine_pcm_unregister(&pdev->dev); return ret; + } if (STM_SAI_PROTOCOL_IS_SPDIF(sai)) conf = &stm32_sai_pcm_config_spdif; -- 2.20.1