Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: H5syFWIQd+kmpgpKXjZxdOQf82lfiky2bmuHF7wNpAAIWVIBlb8ry5JVAOMq8BMW8jGJaUfab2
 OrW+cRC7l7TKi15Mx2PnZ1eOpoQCakci6MnXG+wnowIxWCcQdIhgnqb+/XWJZ7zfa1MWlB/H32
 LRBV4tPMh7xjsjQ8zHozNVZMBey22a0WKQvgYzaGsG2ELGLvcLadjtO42cdFpWVa5C4T6V8bZS
 CfXObXN/FT6jhyT9z1nyujtZiJjZVkiSp4cim4QjP3wxJmghANoWS6VY7ioJ4AXFIG5BFwSnGc
 VZs=
Subject: Re: [RFC PATCH 0/3] net: macb: Wake-on-Lan magic packet fixes
To:     Harini Katakam <harinik@xilinx.com>
CC:     <linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
        "Claudiu Beznea" <claudiu.beznea@microchip.com>,
        Harini Katakam <harini.katakam@xilinx.com>,
        <linux-kernel@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Rafal Ozieblo <rafalo@cadence.com>,
        <sergio.prado@e-labworks.com>, <antoine.tenart@bootlin.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        <linux@armlinux.org.uk>, Andrew Lunn <andrew@lunn.ch>,
        Michal Simek <michal.simek@xilinx.com>
References: <cover.1585917191.git.nicolas.ferre@microchip.com>
 <CAFcVECLkPxN0nk=jr9AxJoV3i1jHBoY4s3yeodHDO2uOZspQPg@mail.gmail.com>
From:   Nicolas Ferre <nicolas.ferre@microchip.com>
Organization: microchip
Message-ID: <9e2ab6cd-526d-f1b5-4bd0-4a8f80d9dd8f@microchip.com>
Date:   Mon, 6 Apr 2020 16:25:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <CAFcVECLkPxN0nk=jr9AxJoV3i1jHBoY4s3yeodHDO2uOZspQPg@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Harini,

On 03/04/2020 at 15:36, Harini Katakam wrote:
> Hi Nicolas,
> 
> On Fri, Apr 3, 2020 at 6:45 PM <nicolas.ferre@microchip.com> wrote:
>>
>> From: Nicolas Ferre <nicolas.ferre@microchip.com>
>>
>> Hi,
>> Here are some of my early patches in order to fix WoL magic-packet on the
>> current macb driver.
>> Addition of this feature to GEM types of IPs is yet to come. I would like to
>> have your feedback on these little patches first so that I can continue
>> investigating the addition of GEM WoL magic-packet.
>>
>> Harini, I know that you have patches for GEM in order to integrate WoL ARP
>> mode [1]. I'll try to integrate some of your work but would need that this feature
>> is better integrated in current code. For instance, the choice of "magic
>> packet" or "ARP" should be done by ethtool options and DT properties. For
>> matching with mainline users, MACB and GEM code must co-exist.
> 
> Agree. I'll try to test this series and get back to you next week.
> 
>> The use of dumb buffers for RX seems also fairly platform specific and we would
>> need to think more about it.
> 
> I know that the IP versions from r1p10 have a mechanism to disable DMA queues
> (bit 0 of the queue pointer register) which is cleaner. But for
> earlier IP versions,

Which IP name are you referring to? GEM, GEM-GXL? What is the value of 
register 0xFC then?

> I remember discussing with Cadence and there is no way to keep RX
> enabled for WOL
> with RX DMA disabled. I'm afraid that means there should be a bare
> minimum memory
> region with a dummy descriptor if you do not want to process the
> packets. That memory
> should also be accessible while the rest of the system is powered
> down. Please let me

Very interesting information Harini, thanks a lot for having shared it.

My GEM IP has 0xFC at value: 0x00020203. But I don't see a way to keep 
DMA queues disabled by using the famous bit that you mention above.

> know if you think of any other solution.

I'm trying all this right now. I keep you posted.

Thanks and best regards,
   Nicolas


-- 
Nicolas Ferre