Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3466647ybb; Mon, 6 Apr 2020 09:27:15 -0700 (PDT) X-Google-Smtp-Source: APiQypK1U9znvQB2LGV26jU5xxYx4rssTul0ES1VedaTRA94lYC/tfpHK5DIUAoZjX9BRyF6HzyC X-Received: by 2002:aca:d78a:: with SMTP id o132mr116244oig.60.1586190435141; Mon, 06 Apr 2020 09:27:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586190435; cv=none; d=google.com; s=arc-20160816; b=QoZHbclctmbkqQyqHnfnMqDWcrIDkyRWxAK+1qFSsY4Rs7NIbI/n3xqfrbRlYq7uir ZZPutqFK+IR2J+1vloEGxbENqv94L7OH6IaaVSg0WlolnZeXOZVKrxsPVfDYXYLvG+J7 r9A6jL694PsD8wvhCzo5/0vIySY4wmeLPGLIZc+YaaDYQ/qLwVVATBs79IRPuDUVD9Kt yjKMYNhpn6oURzeGxC0Bc0dTefj2acLTO293Jo4jvwDKRmqyU8CAgs0gB8w/WkeIpY/b wWMrflPgjZwwb8XAqyD3k7QVdGefihYkX1OpTtUby4QMepeDqecUY9tVUHppw2ZRBQMH 1k0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization :dkim-signature; bh=17nCtfeqSi71cffLAAYudEczCAwQpV2MoZnlr3dlA0o=; b=PawL7UJftPIwXs/ZznGWeVrgr+g90i9Lja5sxOIO0bvibiQMjUCPT0g3AKq6XcXe2u uHWtVC/BaaoALeMGDKzf2Xg6riHkTAh1tZMfCJ8CFvionBK64csn7Wk1HbCHArxqTheU 6iUie9FYwUBxotRdbA9bex26BOcEUM6JVp3jTc7fAh1OIP8rUqT0PIJJ0KzGb9nW8nao uooTexZzHUXigXXOXPt6F1X/Bx40x4iV2iLj+DywvcwhDQSesKnN5lBV1BSWBhX/WGvk myLqfascx6pks+5CB/RJxAXfTEzeFOeiYWZZX1JTk0mUB33Ot1+NNGvDdLlZpnQ2kixT 27NQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=N6DgYuNB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 192si7644295oii.36.2020.04.06.09.27.00; Mon, 06 Apr 2020 09:27:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=N6DgYuNB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729203AbgDFQ0m (ORCPT + 99 others); Mon, 6 Apr 2020 12:26:42 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:55058 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729015AbgDFQ0m (ORCPT ); Mon, 6 Apr 2020 12:26:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586190401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=17nCtfeqSi71cffLAAYudEczCAwQpV2MoZnlr3dlA0o=; b=N6DgYuNBt5Xc8o3fi2oWWO7dbiW6nKap2LBUxE21t1c5pQSkYp1XZSh/dhkAKA54WvY6Bl dWWbtILI/UPCy3tqxCT7oRoqXLLBLVZQRmvRCvX2kmixyYKvu3mgnT8QTok12/YflQpqOG 3lJOTxJUI2dQEVXUJ7GyJs8495J+AiM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-49--c7y-mZpOL2UaIH_H3hUiA-1; Mon, 06 Apr 2020 12:26:37 -0400 X-MC-Unique: -c7y-mZpOL2UaIH_H3hUiA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8CC571007269; Mon, 6 Apr 2020 16:26:35 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-224.rdu2.redhat.com [10.10.112.224]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2325A1001DF0; Mon, 6 Apr 2020 16:26:29 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20200406023700.1367-1-longman@redhat.com> <319765.1586188840@warthog.procyon.org.uk> To: Joe Perches Cc: dhowells@redhat.com, Waiman Long , Andrew Morton , Jarkko Sakkinen , James Morris , "Serge E. Hallyn" , linux-mm@kvack.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds Subject: Re: [PATCH] mm: Add kvfree_sensitive() for freeing sensitive data objects MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <334932.1586190389.1@warthog.procyon.org.uk> Date: Mon, 06 Apr 2020 17:26:29 +0100 Message-ID: <334933.1586190389@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe Perches wrote: > While I agree with Linus about the __ prefix, > the z is pretty common and symmetric to all > the zalloc uses. > > And if _sensitive is actually used, it'd be > good to do a s/kzfree/kfree_sensitive/ one day > sooner than later. How much overhead would it be to always use kvfree_sensitive() and never have a kfree_sensitive()? David