Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3608723ybb; Mon, 6 Apr 2020 11:55:58 -0700 (PDT) X-Google-Smtp-Source: APiQypLxXWTQ1IQY0hgAIPoICouE6UyiH7xli7mT8SKeciASilA9tRdOuXrrjxDdL9Bj+hbeuLr1 X-Received: by 2002:a4a:4505:: with SMTP id y5mr514576ooa.29.1586199358027; Mon, 06 Apr 2020 11:55:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586199358; cv=none; d=google.com; s=arc-20160816; b=IxspgFdyQCLg+QVgMu+s3t44jsv6GW8btQnI7OjuwC4vVJH2/r/NudgE+dccdOeOW4 ht6UxZZ1TDpev8FbcVNkcEuf/ZY6xLPEsV45a/YuUsqCQoFLGnRgHahblUlkFQ97HdEa 1WiLe2tw4qmPacu4E17cEmGLwwDLaq7qST0ikl+SwFIErQv+04jXFCZb0qFfG1EhXeGr JJy7nsbIw1KpYuxdFq0pVn+fPAQ0/uwjERHWkCzXcEdlrzSfjoVJZvn6D/noveEyPsQx Jw77aRdyR8MoQ55zcr/TTkL1aaE38iPX8KRqebc/SpJFGQJF3wF8vWuht+jJjFnC1gwf raqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=g8U9PZuvcH5w4xLQj2gvKeqt5LcgIWXHcVElJKQcRw0=; b=pEnhUvrEXCaFDsWYJfk1XYXUe09J8bwIW5cYDi+/7nV85m1EdDx61tivgSHobySlKR vqnM06wMawukoWFiGv1Dzk4aj0wd84B6BBtLOnxF5BUbtq5uHDM1T6+aZFEmk1hdvAhC cJ0Md4J83bM+gyuGuH0caSBwMRWwEPTQepQefxBR+iXpUBYG2qnTzOnAwAL/N9ZIXEmt iHUp6LKIVn7GuVGH2mQcSgqx7Mh/L2Nl81gQR3h+/A/dbc1+qCKyWZRtnOPr+PmZu7xW /oIcTo+ijOkq5X/7PZqk+UgAaIfy5bqTIchgXgWvIc4PfM0iEpqHDL1VgiQwrIsDlNKq bDsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=CLkT2dXb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w14si213281otl.175.2020.04.06.11.55.45; Mon, 06 Apr 2020 11:55:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=CLkT2dXb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726436AbgDFSyA (ORCPT + 99 others); Mon, 6 Apr 2020 14:54:00 -0400 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:12612 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725957AbgDFSyA (ORCPT ); Mon, 6 Apr 2020 14:54:00 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 06 Apr 2020 11:52:18 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 06 Apr 2020 11:53:59 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 06 Apr 2020 11:53:59 -0700 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 6 Apr 2020 18:53:59 +0000 Received: from rcampbell-dev.nvidia.com (172.20.13.39) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 6 Apr 2020 18:53:58 +0000 Subject: Re: [PATCHv2 1/8] khugepaged: Add self test To: "Kirill A. Shutemov" , , Andrea Arcangeli CC: Zi Yan , Yang Shi , , , "Kirill A. Shutemov" References: <20200403112928.19742-1-kirill.shutemov@linux.intel.com> <20200403112928.19742-2-kirill.shutemov@linux.intel.com> From: Ralph Campbell X-Nvconfidentiality: public Message-ID: <71529d58-e51d-4f36-037d-42e60dd5a8ff@nvidia.com> Date: Mon, 6 Apr 2020 11:53:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200403112928.19742-2-kirill.shutemov@linux.intel.com> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To DRHQMAIL107.nvidia.com (10.27.9.16) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1586199138; bh=g8U9PZuvcH5w4xLQj2gvKeqt5LcgIWXHcVElJKQcRw0=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=CLkT2dXb750W1QoqQPrPP2Ccskw+S6FlQrEi56Cxpi/s26/v1eaQxteeuzNJaSI79 9FoyU3EuIr7geDBdcUspaeucGcP5wpUisVzHBk5wjYxzKYea9kNEQWJb7NrbHjHvfA 9jzh6gvXAOxMc7N1oa3dKhJ9W0nlYchji+fm4OHB2qt4SHQR6jUqb3e+/gZM2tH/T6 j+OpzkO+//pMMn1EjUeq3/UPT5BoyfsxijanARsQDOefBfJBa9laR7cJnayjUprlwg a29OCmki2ynnvWcW1RBs1KcajCzQXLtRP2lYI+UPNL8QpTzqlas8f1NYBY4z9QGZab qX9dMd8BzYSRQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/3/20 4:29 AM, Kirill A. Shutemov wrote: > The test checks if khugepaged is able to recover huge page where we > expetect to do so. It only covers anon-THP for now. > > Currenlty the test shows few failures. They are going to be addressed by > the following patches. > > Signed-off-by: Kirill A. Shutemov One minor nit below but otherwise looks OK. Reviewed-by: Ralph Campbell > + > +static void collapse_signle_pte_entry(void) > +{ Shouldn't this be collapse_single_pte_entry()? (and change the places where it is called)