Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3611553ybb; Mon, 6 Apr 2020 11:59:47 -0700 (PDT) X-Google-Smtp-Source: APiQypIumgFTeL3Iao4K8XwwJvqYN8f6xwPE1s0VPeR1rnP+7e165E8KbsY1u9DuTKv5z8dEvfAe X-Received: by 2002:aca:ec16:: with SMTP id k22mr633319oih.177.1586199587464; Mon, 06 Apr 2020 11:59:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586199587; cv=none; d=google.com; s=arc-20160816; b=xF0ijDJRzATXCPFmS2A4zTxwIhIENAnLvvxNiHe0Di9+BDAvY9dl82xTabaIyf0fiV PN334NTjQB7j9o2VxnW2T+kByKOgEY+CWEoR7VpVLYcQ4g3iTosJr3q0qxPP4YEXRlQU i4OogLDd/WyZE2nTGkKcBVKQScGI5rJUsXg4cM3+cEHoiA5zj50NO0YxarS1gs2JqXPN qOSNfi35Kf0ycJ+DtXdIvqfswgs+1c7LdLNyO1LiZR1P3aRphk2CydFyzQyPKnMiYXCJ +FZEkAG2w9Oarp3qrFzGjVto8yZDTr2oSyjHD8elWzAtBlVMJ3FD8R8pG21ht3yXjJ5v mQSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=o2YOjNGwEALpzr6ldAL/EJ7+Mp70+nUIZNI7t+BCnl0=; b=pU4IQUfjA2IPXAp0KlLCSjV4tc+TTKUMJzP8vpX5wnBDMOpbDfSvGw0SV5cuLcZ4L+ O4m1g3nMgSZ8dRR7+lssmpr2l6FmgYjXMoTzxC2n/AtJ/kcim71X6pCiLBtzHwnCHBrE v+zIRB96x+zTkoN563e0FA301jc8gDwOC+XdcoWffVVoXTb7vw8Cwv236tyPHo4PAvXT grf91dcUpYT8nu8OmHKF8xaDrO9cU8EI6vymm+wbb/hAKiguBmvdy6ztmFxQlrWjsLjb G11PcmOvgDNLMaNWj45wEB4N+zAff9CT/6vdosEa26WpHuoNJYfeTafQA+cklA3y1b/Q 762Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=lAjFBTu4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l129si153669oif.15.2020.04.06.11.59.35; Mon, 06 Apr 2020 11:59:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=lAjFBTu4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726310AbgDFS7D (ORCPT + 99 others); Mon, 6 Apr 2020 14:59:03 -0400 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:12884 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725876AbgDFS7D (ORCPT ); Mon, 6 Apr 2020 14:59:03 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 06 Apr 2020 11:57:21 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 06 Apr 2020 11:59:02 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 06 Apr 2020 11:59:02 -0700 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 6 Apr 2020 18:59:02 +0000 Received: from [10.2.164.193] (172.20.13.39) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 6 Apr 2020 18:58:58 +0000 Subject: Re: [RFC PATCH v6 6/9] media: tegra: Add Tegra210 Video input driver To: Dmitry Osipenko , , , , , , CC: , , , , , References: <1585963507-12610-1-git-send-email-skomatineni@nvidia.com> <1585963507-12610-7-git-send-email-skomatineni@nvidia.com> From: Sowjanya Komatineni Message-ID: Date: Mon, 6 Apr 2020 11:58:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To DRHQMAIL107.nvidia.com (10.27.9.16) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1586199441; bh=o2YOjNGwEALpzr6ldAL/EJ7+Mp70+nUIZNI7t+BCnl0=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=lAjFBTu4nKWpTL7Ihnm6Da8jZ0JDs32OAPpY+hl9+SriQG/IP60ClPGUFhp0tAlsn mw9+/7mDCmyF+oMZmKxcPvD48Juz8wnz7dWYi3BmO+eyqvsGmIbk/NNmoGL9+EEwkA hDERDaQC8s93mz86g6HRIwsQrkGixY86AYTodhDl4f1bPU03k8TnUF+orTq+mgt0MA huJtbijFv8134PZXaZZZ9MrPXWfXSTpKoPLcNNhBgahW+mUtTlHoAWPiemQWr9BlBP LKDbRUgrHEUopI8G59NWQeD+nYCWagN2tIW2s9lmJ9pHu1/GZGVxr4kK4f0IbudJ/p OPp9GiRkUvFww== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/5/20 12:37 PM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 04.04.2020 04:25, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > ... >> +static int tegra_csi_init(struct host1x_client *client) >> +{ >> + struct tegra_csi *csi =3D host1x_client_to_csi(client); >> + struct tegra_video_device *vid =3D dev_get_drvdata(client->host); >> + int ret; >> + >> + vid->csi =3D csi; >> + >> + INIT_LIST_HEAD(&csi->csi_chans); >> + >> + if (pm_runtime_enabled(csi->dev)) { >> + ret =3D pm_runtime_get_sync(csi->dev); >> + if (ret < 0) { >> + dev_err(csi->dev, >> + "failed to get runtime PM: %d\n", ret); >> + pm_runtime_put_noidle(csi->dev); >> + return ret; >> + } >> + } else { > RPM is supposed to be always available on Tegra nowadays. Sorry I was not sure if its all the time enabled, so added in v6. Will remove check and explicit runtime calls...