Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3751438ybb;
        Mon, 6 Apr 2020 15:08:47 -0700 (PDT)
X-Google-Smtp-Source: APiQypKOFyRrnBBbZd0wYrQW/5vtLiKCPQX42wtafrAgG/qXAZXoxsIQTbGQhqyBPCzCuwrIL8Xl
X-Received: by 2002:a9d:18f:: with SMTP id e15mr1042027ote.42.1586210927260;
        Mon, 06 Apr 2020 15:08:47 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1586210927; cv=none;
        d=google.com; s=arc-20160816;
        b=EcecosmMq5fBllDcw81KcOkamKMs2JsndTQUIJUOmQyGicxBDDl76SFxotB1U25viW
         r2hXFXDX2JLreC0ALCC3tQ/nQcz+iVaEivk1Ry8MhmFZ6s3ZVawS/3CTuIxysIl7JBYO
         cOOonZKIF4smH7CSwyV9GL4D+3BKhGdKAjq9CyvU8Q2X8p1EjpR1+CWnPxdvhClyXCnY
         jlM8veU0tRC4nIGDaHpy1WPU5fyUiERpnwQkEeUvShQDg1RsvI+ua8Vu7GM4JtSfe7HC
         mNxokTjjqa+hjYfN+L47hmZrmKlXDziPKpwKykRsRMt786WTjRxm3fPfmrw8WnQRK9Ik
         Er+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:references:cc:to:from:subject;
        bh=HpwSmhwcv0DQ/SMY/515qVkKZ6WeiMUhqqpKIo4nZuE=;
        b=mhRUiPCAUwq48EiFQK0p2Q2DzJfn/C2tvJzCr8s71nfHku5k/fjViNHcM3JqkcIruV
         kkAWDIoEFS3rXDKm42S5dz6nr8bpgux0eTaRzY5DE32XkgQHLWnkKcg6Ni5udIGRRbZ5
         CCej91vYXc/ccu2EV09chmtBeGOTf2dIzjBaniRe/LqzTZJKdmffCdMTbLUEVmEOlQ2Y
         ylWPPgnxK8f+F9xLUv5QU0tKsief1xDVdCCXxa4xm8xy8nLhHISEd7v7brNPrlvSArtT
         W0jRbciG9466tJYoBrHeMCOrixvuHdY2AdilGEBOAfjM7kMWD9x5VUQpdFHbOWu9q50O
         wbZg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b="Y/WMbuTz";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id r21si386953otp.320.2020.04.06.15.08.35;
        Mon, 06 Apr 2020 15:08:47 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b="Y/WMbuTz";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726331AbgDFWH5 (ORCPT <rfc822;rajatbajpailinux@gmail.com>
        + 99 others); Mon, 6 Apr 2020 18:07:57 -0400
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:1158 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725933AbgDFWH5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 6 Apr 2020 18:07:57 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5e8ba8070000>; Mon, 06 Apr 2020 15:07:03 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Mon, 06 Apr 2020 15:07:55 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Mon, 06 Apr 2020 15:07:55 -0700
Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL109.nvidia.com
 (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 6 Apr
 2020 22:07:55 +0000
Received: from [10.2.164.193] (172.20.13.39) by DRHQMAIL107.nvidia.com
 (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 6 Apr 2020
 22:07:54 +0000
Subject: Re: [RFC PATCH v6 6/9] media: tegra: Add Tegra210 Video input driver
From:   Sowjanya Komatineni <skomatineni@nvidia.com>
To:     Dmitry Osipenko <digetx@gmail.com>, <thierry.reding@gmail.com>,
        <jonathanh@nvidia.com>, <frankc@nvidia.com>, <hverkuil@xs4all.nl>,
        <sakari.ailus@iki.fi>, <helen.koike@collabora.com>
CC:     <sboyd@kernel.org>, <linux-media@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1585963507-12610-1-git-send-email-skomatineni@nvidia.com>
 <1585963507-12610-7-git-send-email-skomatineni@nvidia.com>
 <200bb96e-2d07-764f-9e14-55538dc742fd@gmail.com>
 <23bfab09-b464-6e51-9843-06d13000e9b9@nvidia.com>
 <be77b0ef-d605-8357-4180-f40b2886d07a@gmail.com>
 <08cd31d5-e8b9-4d3a-fb0e-0e4462947d96@nvidia.com>
 <12a834ac-52b1-6dc0-7d3a-3e6a1fa85a2a@gmail.com>
 <e3712e7b-b335-b35b-a94f-24eb85122dca@nvidia.com>
 <b1726d33-0d35-9323-a747-407148d0104e@gmail.com>
 <eb80178f-30f4-8f46-51cd-ea3f4914b81d@nvidia.com>
 <dd16c560-ba8f-e7df-5dc4-5227e0043196@nvidia.com>
 <fea4f0a1-4a20-34d4-9eda-e4a599eeeffc@nvidia.com>
Message-ID: <760d071e-0cbc-b3eb-9231-fb9f9ecb44a6@nvidia.com>
Date:   Mon, 6 Apr 2020 15:07:53 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <fea4f0a1-4a20-34d4-9eda-e4a599eeeffc@nvidia.com>
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To
 DRHQMAIL107.nvidia.com (10.27.9.16)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1586210823; bh=HpwSmhwcv0DQ/SMY/515qVkKZ6WeiMUhqqpKIo4nZuE=;
        h=X-PGP-Universal:Subject:From:To:CC:References:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=Y/WMbuTziPO5+ZL/2ukt1TSrFKEQXnqx2rlUk2QM3l2SCZ6K3o4Cs3Ubx4A/EU6BC
         nyj4U/1BM0DsBSfrcwtIPKhTFoqi19r6hYcHAeTGIP0cjPTvS08Bs8WgVfvfv+mPeN
         JbEAqo0ITJ8Sd7V/8ulFf2IuIoL7mD/WveyHOOqWHosxzlhIeUKaqWrq0XM2ceDhqQ
         zJhOFJfbMSFOrtmR4Gy0qaJdvEVE2gJdRTr1bDmDgVzK0NOYev0ETUpYexXMK3X/gS
         9MQhtNRrUdhEx1poKESQzf0yh85VbkbXqzIyvoBCw9Fq1qJI38QZRm8QE/dQgtHZtB
         pvWVwMmw/+RYg==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/6/20 3:00 PM, Sowjanya Komatineni wrote:
>
> On 4/6/20 2:39 PM, Sowjanya Komatineni wrote:
>>
>> On 4/6/20 2:15 PM, Sowjanya Komatineni wrote:
>>>
>>> On 4/6/20 2:11 PM, Dmitry Osipenko wrote:
>>>> External email: Use caution opening links or attachments
>>>>
>>>>
>>>> 07.04.2020 00:02, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>>>>>>>>>> Am I understanding correctly that this thread will take 100%=20
>>>>>>>>>> CPU,
>>>>>>>>>> spinning here, if more than 2 frame-captures queued?
>>>>>>>>> on more than 2 frames captures, it breaks thread and on next=20
>>>>>>>>> wakeup it
>>>>>>>>> continues
>>>>>>>> The wait_event() won't wait if condition is true.
>>>>>>> condition is checked when waitqueue is woken up
>>>>>> https://elixir.bootlin.com/linux/v5.6.2/source/include/linux/wait.h#=
L462=20
>>>>>>
>>>>> process is put to sleep until the condition evaluates to true or=20
>>>>> signal
>>>>> is received.
>>>>>
>>>>> condition is checked each time the waitqueue head is woken up.
>>>> This is a wrong assumption in accordance to the code.
>
> process is in sleep until the condition is evaluated and when=20
> condition is true wakeup still happens only when wake_up on waitqueue=20
> is called
>
> This is the reason for using this to prevent blocking while waiting=20
> for the buffers.

w.r.t capture list update, wakeup happens when wake_up on waitqueue is=20
called.

wakeup also happens on kthread stop signal event.

>
>
>>>
>>> when every buffer is available as long as we are in streaming, we=20
>>> should process it.
>>>
>>> So if wake up happens when list has buffer, it will be processed but=20
>>> at a time we limit processing 2 simultaneous buffer capture starts=20
>>> only.
>>>
>> Fixing typo.
>>
>> I meant when ever buffer is available as long as we are in streaming,=20
>> we should process it.
>>
>> So capture thread processes as long as buffers are available from=20
>> user space limiting 2 simultaneous trigger of captures and thread=20
>> will be in sleep when capture buffers list is empty or no stop thread=20
>> is signaled.
>
>
>