Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3811140ybb; Mon, 6 Apr 2020 16:34:47 -0700 (PDT) X-Google-Smtp-Source: APiQypJG75kcB0vKldO2zygA909SyLAu5awubabBsQ5cziMSZFcg4UBaqShTTibWqse18V9u7Rik X-Received: by 2002:a9d:3a62:: with SMTP id j89mr18151145otc.45.1586216087056; Mon, 06 Apr 2020 16:34:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586216087; cv=none; d=google.com; s=arc-20160816; b=jdgDBGmuM5v7jgjOe+BXUtlVfZNrTMGt4LHAOjmVvavCuWYSoCjQDEhHfzvzM+oZiS /VVM6sO6co6UAMwHsGNCSgq1WCAgWPKHZXNySn6vfbD0NxOzmAAVNYRDjSGGHvgdtOcF IdW6pAkS7Ujfk7JwZYmo+HriZQ8FDyErqoTHdAcG4YU3cDnEKOz4RavdY1HwgJ8TGWqt spqadroXD8HHVzFW1xilRcujlQ+PXUxjs2TM/dWBO/iAwtRDKYE42M2gBSemBjTHdufH zyXTQHNcRZKWqB58CBK978rrQoS4PGfRLWPqLVa+5wWaSptrafXRq3l8NQeotVQt24lN rZRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=APdJ2bbJpdKbX+Sk+LIMoTdwNG0LJpHDXmC1o7gJlEs=; b=aG9uRH9g/WKSiT2J9c4f+MZBTz1rt9piAMoxrCK/s95DjK84WfyLTiDm9rAbyLek3P 6IRwZZ6Hmp9Q+X/b995zJoUDJ/7wo0mBoEmcRacRulxMhPm+6fiGNSqYxcbV/ne954t4 t7T1ityya246V5gGihtt/e/iQg1NohDGkSE+cF49leUbV2za6VccrS498PBgDum5pwiV 4T1UXJ201X14j8PSQ/oZzK7OKkhIHmx9anlFy77F0Uj8VBMXExjtqRcHW1fUqFUf/NwR oBF1lTGxBv7FJoUIVBcP1cZv3Gcll9LmUpYux2tA6j5tsMXF/mjFIAAkCPbVaRuFUxBp snpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=msdjWJ+Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z6si463205otm.218.2020.04.06.16.34.34; Mon, 06 Apr 2020 16:34:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=msdjWJ+Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726380AbgDFXd5 (ORCPT + 99 others); Mon, 6 Apr 2020 19:33:57 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:40153 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbgDFXd5 (ORCPT ); Mon, 6 Apr 2020 19:33:57 -0400 Received: by mail-pg1-f194.google.com with SMTP id c5so808094pgi.7 for ; Mon, 06 Apr 2020 16:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=APdJ2bbJpdKbX+Sk+LIMoTdwNG0LJpHDXmC1o7gJlEs=; b=msdjWJ+QJBaucO7GD9Jl+hBSA0PUl2BSJiwTwyO6NYTKgo++vqVg0TAlaenuKxaTZH GYQsp2YXDWbKyhaXMpwDDw/f8KKk2nByDrmkaR9QtCgoObBvBvsJovisx7niVMxr9702 HRN6s+4JhXbxnccjpu+npnHfsUlpmPlkRjJSupNg44UW8zSTOsACZtlAYb/VLrwdf8Et xI+Hq3cQG1FvhxS54t33C0gsvLaBf9S7l6fbWaRVz+bq34EB+IoQoBhXm3AQ+gdogGfb O/2EDSjYBb+Bh5JHEyapryREF1j2xeLhg4WgvCTPCJsDuS/cIFjxCJ9foE2VJEeRXbNp fBwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=APdJ2bbJpdKbX+Sk+LIMoTdwNG0LJpHDXmC1o7gJlEs=; b=sZ7S+u3iyB/GVm5q4rkAx9Y5fHMiOlpNrCOTAQbsH+mM97U9U8U8mD95imBD5WaZGz rz4K9YXjCcKh7Rt3BbG0GxPRR263mYmB7MPv9Cj6QDdMezizxoK+4yYM6RfAvIo6vYFz 0/jsl4tDWNjt3UuYgyRUP/8Dg9vjMxFFdwJoTnK0f4nEktirYyNeieyvyqj5PxHH5SYB b8D8+aY5G5tJ3LG0voxXV3PjDFUBy8y6f33tr1QlVOhMhtjATvcYCvJbD4kCfJE0+FiU RXiyLreh82ao9Tneq6NeviyzvX0K7OJWbeNk8Ea1TWNoX1z+tnESBcQPtLKPDgZvR7Tj az4w== X-Gm-Message-State: AGi0Pua73ZtJ7GvPMbVLo5NSFZnKT72fAAdupV9dHJi1hDEXVf4Fcu/e Y2EM9478oJ+0jk6Dg0Zbz2B0Euw8mQqLoA== X-Received: by 2002:a63:9a1a:: with SMTP id o26mr13288335pge.447.1586216035546; Mon, 06 Apr 2020 16:33:55 -0700 (PDT) Received: from ?IPv6:2605:e000:100e:8c61:7d7c:3a38:f0f8:3951? ([2605:e000:100e:8c61:7d7c:3a38:f0f8:3951]) by smtp.gmail.com with ESMTPSA id r189sm11918932pgr.31.2020.04.06.16.33.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Apr 2020 16:33:54 -0700 (PDT) Subject: Re: [PATCH] io_uring: remove redundant variable pointer nxt and io_wq_assign_next call To: Colin King , Alexander Viro , linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200406225439.654486-1-colin.king@canonical.com> From: Jens Axboe Message-ID: <434016cd-bf33-ce65-a86b-69a565d62a61@kernel.dk> Date: Mon, 6 Apr 2020 16:33:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200406225439.654486-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/6/20 3:54 PM, Colin King wrote: > From: Colin Ian King > > An earlier commit "io_uring: remove @nxt from handlers" removed the > setting of pointer nxt and now it is always null, hence the non-null > check and call to io_wq_assign_next is redundant and can be removed. Thanks, applied. -- Jens Axboe