Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1585892447-32059-1-git-send-email-iamjoonsoo.kim@lge.com> <20200406091814.17256-1-hdanton@sina.com>
In-Reply-To: <20200406091814.17256-1-hdanton@sina.com>
From:   Joonsoo Kim <js1304@gmail.com>
Date:   Tue, 7 Apr 2020 09:40:43 +0900
Message-ID: <CAAmzW4MZG9m+wDYSnG3ZGy_9X_ajv6eU8AdtGyrSJ7kW1K3TQQ@mail.gmail.com>
Subject: Re: [PATCH v5 02/10] mm/vmscan: protect the workingset on anonymous LRU
To:     Hillf Danton <hdanton@sina.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Hugh Dickins <hughd@google.com>,
        Minchan Kim <minchan@kernel.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Mel Gorman <mgorman@techsingularity.net>, kernel-team@lge.com,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2020=EB=85=84 4=EC=9B=94 6=EC=9D=BC (=EC=9B=94) =EC=98=A4=ED=9B=84 6:18, Hi=
llf Danton <hdanton@sina.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
>
> On Fri,  3 Apr 2020 14:40:40 +0900 Joonsoo Kim wrote:
> >
> > @@ -3093,11 +3093,10 @@ vm_fault_t do_swap_page(struct vm_fault *vmf)
> >       if (unlikely(page !=3D swapcache && swapcache)) {
> >               page_add_new_anon_rmap(page, vma, vmf->address, false);
> >               mem_cgroup_commit_charge(page, memcg, false, false);
> > -             lru_cache_add_active_or_unevictable(page, vma);
> > +             lru_cache_add_inactive_or_unevictable(page, vma);
> >       } else {
> >               do_page_add_anon_rmap(page, vma, vmf->address, exclusive)=
;
> >               mem_cgroup_commit_charge(page, memcg, true, false);
> > -             activate_page(page);
> >       }
> >
> >       swap_free(entry);
> ...
> > @@ -996,8 +996,6 @@ static enum page_references page_check_references(s=
truct page *page,
> >               return PAGEREF_RECLAIM;
> >
> >       if (referenced_ptes) {
> > -             if (PageSwapBacked(page))
> > -                     return PAGEREF_ACTIVATE;
> >               /*
> >                * All mapped pages start out with page table
> >                * references from the instantiating fault, so we need
> > @@ -1020,7 +1018,7 @@ static enum page_references page_check_references=
(struct page *page,
> >               /*
> >                * Activate file-backed executable pages after first usag=
e.
> >                */
> > -             if (vm_flags & VM_EXEC)
> > +             if ((vm_flags & VM_EXEC) && !PageSwapBacked(page))
> >                       return PAGEREF_ACTIVATE;
> >
> >               return PAGEREF_KEEP;
> > --
> > 2.7.4
>
> Both changes other than
> s/lru_cache_add_active_or_unevictable/lru_cache_add_inactive_or_unevictab=
le/
> are likely worth their own seperate commits with a concise log.

IMO, all of the changes in this patch provides just one logical change
for LRU management
on anonymous page so it's better to be together.

Thanks.