Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Subject: Re: [PATCH] drm/i915: Force DPCD backlight mode for HP Spectre x360
 Convertible 13t-aw100
From:   Kai-Heng Feng <kai.heng.feng@canonical.com>
In-Reply-To: <41FD4AD2-81F9-45E8-B5D6-9CC255D0581B@canonical.com>
Date:   Tue, 7 Apr 2020 14:07:33 +0800
Cc:     Thomas Zimmermann <tzimmermann@suse.de>,
        "open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: 8BIT
Message-Id: <1F57CA05-3E23-4CA8-A138-6785906ED465@canonical.com>
References: <20200323053528.3147-1-kai.heng.feng@canonical.com>
 <41FD4AD2-81F9-45E8-B5D6-9CC255D0581B@canonical.com>
To:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        mripard@kernel.org, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        "Deucher, Alexander" <alexander.deucher@amd.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Mar 27, 2020, at 19:03, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
> 
> Hi,
> 
>> On Mar 23, 2020, at 13:35, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
>> 
>> There's another OLED panel needs to use DPCD aux interface to control
>> backlight.
>> 
>> BugLink: https://bugs.launchpad.net/bugs/1860303
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> 
> Would it be possible to review this?
> I'd like to send a similar quirk for a new panel, and I want to avoid causing any merge conflict.

Another gentle ping...

> 
> Kai-Heng
> 
>> ---
>> drivers/gpu/drm/drm_dp_helper.c | 2 ++
>> 1 file changed, 2 insertions(+)
>> 
>> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
>> index 8ba4531e808d..a0d4314663de 100644
>> --- a/drivers/gpu/drm/drm_dp_helper.c
>> +++ b/drivers/gpu/drm/drm_dp_helper.c
>> @@ -1301,6 +1301,8 @@ static const struct edid_quirk edid_quirk_list[] = {
>> 	 * only supports DPCD backlight controls
>> 	 */
>> 	{ MFG(0x4c, 0x83), PROD_ID(0x41, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>> +	/* HP Spectre x360 Convertible 13t-aw100 */
>> +	{ MFG(0x4c, 0x83), PROD_ID(0x42, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>> 	/*
>> 	 * Some Dell CML 2020 systems have panels support both AUX and PWM
>> 	 * backlight control, and some only support AUX backlight control. All
>> -- 
>> 2.17.1
>> 
>