Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4082145ybb; Mon, 6 Apr 2020 23:55:57 -0700 (PDT) X-Google-Smtp-Source: APiQypIRAEfvDLrEQot9EZIpHgn31fBDkQ1QGTwpMhnDE4p+CEb0L2smFa3d2VT6V3QQKDns1oKt X-Received: by 2002:a05:6830:154:: with SMTP id j20mr386081otp.299.1586242556912; Mon, 06 Apr 2020 23:55:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586242556; cv=none; d=google.com; s=arc-20160816; b=CMP8BOtlREq9Q5bNg5rRlpBiI9MUqKE1WEMyJoUPKTJhF6oPUMBsIOiR0U6k0IImUK prH36bMrbSdTXeFEU/yOWPKZf8DDXXDSBo/f1T+3eWKB7IwBwwjYXtAZyCKTp9CFMNx7 gsFkiTunBq2Ie4yeszlDVStivINI750YEx9JT48GHBy5vN6vDkIMv9LKo/+mqqk+r8N6 ZdX9jrl6KvQ1YhU00ptVp43UURv2iKG6hkTrXMJjy85pQwKTZShVT+46ErSM4gzZDIxo zRJ9Y5FsZJzrL9ttirr/pU13JLghveVZNOyrA3Vj4/11vK8bL2n5NDRm0ls97NOXBQ3W m1Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date; bh=1aRnXNxeYNnOJ4a+QqBPQz1vguoO06TJjLU7cKz1rSs=; b=OM1KwUOmRuSgdddMp4KvqOfpb1QOvYE3810odugYEmLZxZhWXVLgDaWkDLo/Ni3R2B AWdVPTZheu81Flk6LpLGnafqmmytcT7JPXeDrnmWje+GFfHjo8Vc+69UJsnhhaIlq9Tu Z+EzsrERh9VLP6mR5V32d2ohYLKgVckgdznvVJ9pHiW9QNZ9cNQ3vkPavUTDsnWGYQAD tRCFyPMJBMv2aZNzm02tLB9ZhyyOGFpFd0RMcWT7O9suUmU5W0q+r6pneRM+lwS3MMGx uOwKo7Hi4Ky/gR2t2kG4Hu3W+QgFEuzPhq0bO5ilkMRfZaJTct+FlNvKUc+vVFlt2BaP UDfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m23si951588ots.325.2020.04.06.23.55.45; Mon, 06 Apr 2020 23:55:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726901AbgDGGzD (ORCPT + 99 others); Tue, 7 Apr 2020 02:55:03 -0400 Received: from verein.lst.de ([213.95.11.211]:36674 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726591AbgDGGzD (ORCPT ); Tue, 7 Apr 2020 02:55:03 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 8435768BEB; Tue, 7 Apr 2020 08:55:00 +0200 (CEST) Date: Tue, 7 Apr 2020 08:55:00 +0200 From: Christoph Hellwig To: "K. Y. Srinivasan" , Stephen Hemminger , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra Cc: x86@kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org Subject: hv_hypercall_pg page permissios Message-ID: <20200407065500.GA28490@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, The x86 Hyper-V hypercall page (hv_hypercall_pg) is the only allocation in the kernel using __vmalloc with exectutable persmissions, and the only user of PAGE_KERNEL_RX. Is there any good reason it needs to be readable? Otherwise we could use vmalloc_exec and kill off PAGE_KERNEL_RX. Note that before 372b1e91343e6 ("drivers: hv: Turn off write permission on the hypercall page") it was even mapped writable..