Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4105839ybb; Tue, 7 Apr 2020 00:28:52 -0700 (PDT) X-Google-Smtp-Source: APiQypLDE9lJbYdcuJ27xcXkBVDzfjqoxyQIv6/5c2SEUd2fmnWoAnF5XiaADpwsnxBMxUzKHmko X-Received: by 2002:a05:6830:144e:: with SMTP id w14mr500355otp.75.1586244532432; Tue, 07 Apr 2020 00:28:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586244532; cv=none; d=google.com; s=arc-20160816; b=FUG5D3KMU018ilNo5oAQcvTdDoWM970Lru2aUFYYy7hFDtJlDUEKIrchx+0gvt3G4K jTeQPHSJLf5xSUmE0INhKWEnEudxv8Lt0DHX7b8oQ2JhtPV+6yYCz++fmxz8Rs4Tyfp4 r3CxoACck/awWTwILAQAcVyvPFkq4Y+zCoy598vowevIkK7d1zlrwvcJwT2Rv2RO9UXN 5y9ATaFqzLcxAqCAO9s/JY1er2JSnxsa8Y82V//ZJ2ZAAEOixGjmUhmxiUC1FgiFMylw j/d/DWpjEWppS+50hdiK0EXshkUeqnihWxtHWyLxTP8uCv0MQTdoHG6EfGXiYIfLYakb HS3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=7MZAxxGVYE6IO/tX19kNiAQeKs8JH+78I7IbTMQSWyI=; b=YRu+MYWAvNZbJngUPA0LujMwAByPUFUyPBRxJRauUTGgwVl3hF1ZaL0ufZOaP3xsGD DlRuB9FVxZFXN2J4A+1j0GoIzic27li81Qjo1npIn5TebtJMfTdVAQFfYIyHzUa30Ehy eWAVEo6tWzTMWkk8zfSx18Cr5CAWru5GYyCr7Jmt69M0EcLBZm++VA3AfLTpKG5A2wWI e7eSIU22DQ0+GmexqeLTclB8T93zRCu7VYeGYKNpKhi3KRpopQV4RjRAYak1N1UXASFB Bbh8CDCf2eRLYfGF88sR9AOSEQ29/U1I/josE7Fq+KalACJZGJePrdhjSSEBVWNkP9hv U81w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=Hkp1mQEM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c9si1193885ots.110.2020.04.07.00.28.41; Tue, 07 Apr 2020 00:28:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=Hkp1mQEM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727756AbgDGH16 (ORCPT + 99 others); Tue, 7 Apr 2020 03:27:58 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:47116 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727666AbgDGH16 (ORCPT ); Tue, 7 Apr 2020 03:27:58 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0377RaUh152439; Tue, 7 Apr 2020 07:27:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2020-01-29; bh=7MZAxxGVYE6IO/tX19kNiAQeKs8JH+78I7IbTMQSWyI=; b=Hkp1mQEMoF9S47xOlwF+ramtxnOSy+CzV1EvmoJnS86J5xJ/Qv/OeNmbyv/EeW+EyK9L rVYlOh3GvGGIdjqaBOR9Di8P8YpGH52Nm9TkznOGSZR6Ve9myIuhTAMhZnGcB01L/aOs dXzHlxMAEnboIXgmptIOmtYAWkUIOAyr7RVDZWJ6ZuBpwmGoC9ejwHbiuE4JKlpfXfMx Wjz8GtS+h3sQIcO/Kgbp6hD7x+RaftlZURC9vzUm2xidj9mOkuGJBbnmZepb7zlqDoSV 1vhJBJMU8ppSRx8HkFzVxeiZwjnXWoKghB2zWn8ksLlwdVkniZL9EHdMm+ybcW2B/zAR Ug== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 308ffd93j7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 Apr 2020 07:27:36 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0377RSOV151398; Tue, 7 Apr 2020 07:27:35 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 30741d9u5q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 Apr 2020 07:27:35 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0377RXD7020646; Tue, 7 Apr 2020 07:27:34 GMT Received: from linux-1.home (/92.157.90.160) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 07 Apr 2020 00:27:33 -0700 From: Alexandre Chartre To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, jpoimboe@redhat.com, peterz@infradead.org, jthierry@redhat.com, tglx@linutronix.de, alexandre.chartre@oracle.com Subject: [PATCH V2 3/9] objtool: is_fentry_call() crashes if call has no destination Date: Tue, 7 Apr 2020 09:31:36 +0200 Message-Id: <20200407073142.20659-4-alexandre.chartre@oracle.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200407073142.20659-1-alexandre.chartre@oracle.com> References: <20200407073142.20659-1-alexandre.chartre@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9583 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 phishscore=0 malwarescore=0 bulkscore=0 spamscore=0 adultscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004070062 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9583 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 priorityscore=1501 impostorscore=0 malwarescore=0 mlxlogscore=999 lowpriorityscore=0 clxscore=1015 phishscore=0 mlxscore=0 bulkscore=0 adultscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004070062 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix is_fentry_call() so that it works if a call has no destination set (call_dest). This needs to be done in order to support intra- function calls. Signed-off-by: Alexandre Chartre --- tools/objtool/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index c7fcaddfaa8a..c0da033a40c5 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -1367,7 +1367,7 @@ static int decode_sections(struct objtool_file *file) static bool is_fentry_call(struct instruction *insn) { - if (insn->type == INSN_CALL && + if (insn->type == INSN_CALL && insn->call_dest && insn->call_dest->type == STT_NOTYPE && !strcmp(insn->call_dest->name, "__fentry__")) return true; -- 2.18.2