Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4136679ybb; Tue, 7 Apr 2020 01:14:53 -0700 (PDT) X-Google-Smtp-Source: APiQypJtpLsq1cc47tc9u503nF8uPw4LoU1F1c+b2wRtCZORxWgLPTB5TwsU+eTdgCSg2ah0SPuz X-Received: by 2002:aca:3110:: with SMTP id x16mr807367oix.47.1586247293610; Tue, 07 Apr 2020 01:14:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586247293; cv=none; d=google.com; s=arc-20160816; b=tAfGAsK2FJeJ9e5aPj5y04H8zDU55+b23OSxgIH9htdaHf65FoXvTLPbvMB2DFSRFp fzmC+6YyI9Eril7cCDvs/VXHCSt8AklUDf9MYrwdAFJGfa7yn7Ihz0M+dutmZ3vKyzLE X/21AXO5Ei4NDOjFE1XdU1qPVoBGC8LsccVaVQ8nMZWsh4DQy108stWijVP9WxD5Nua/ Ev/06osM3X9Y2Tvvo46t7GeMgcOXudApsxTH5dqtROKv0mdoQc2UPb22TBBaMkWqtcfl LJ6HGwcTqW5HYRBtoVBcBlAFKzzYqzB6X1/AGcueVMdct9/LgtqAbrh17l8EeiDew9bT xvhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=yBeRH2yDDpExHabEfQRS6NxXPGUsYxBO9EarZX9ROzI=; b=CM/RGr1qq+ezunMyUe9rhKkGog2IXUhCaaA17sqVhZkscq3rzFF6VSGbTwApsxY4hX KF2jCICAZkrEyRK8h846vzDtmetnnWrqG117I0rl4c+JoE+ooycYVEkKyEA4TALXVuA/ 7Ny+5rgBdE0i3v3Imsofp+WsRZI06AhNE1LkZ/IfZ6gZLXskaBdzJTVxloU1wuQXnXa4 CwJe1+i2wmhrjnPMPj5/gS/UPT8M37FtP3PPsFh+s3n3DWs/y3mgCKh9iA9JK7Qt2ZbJ KR5WbSz0c3paELwN+luQcETcKDqWytY2e647/25JVJ/C7CB0WpFUCnrBG0qTXZFt246j ZEyw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f41si928780otf.280.2020.04.07.01.14.41; Tue, 07 Apr 2020 01:14:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727931AbgDGIOH (ORCPT + 99 others); Tue, 7 Apr 2020 04:14:07 -0400 Received: from proxmox-new.maurer-it.com ([212.186.127.180]:14397 "EHLO proxmox-new.maurer-it.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726687AbgDGIOH (ORCPT ); Tue, 7 Apr 2020 04:14:07 -0400 X-Greylist: delayed 555 seconds by postgrey-1.27 at vger.kernel.org; Tue, 07 Apr 2020 04:14:06 EDT Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 28CD14597C; Tue, 7 Apr 2020 10:04:50 +0200 (CEST) Subject: Re: [PATCH] net/bpfilter: remove superfluous testing message To: David Miller , bmeneg@redhat.com Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20200331130630.633400-1-bmeneg@redhat.com> <20200331.100806.878847626011762877.davem@davemloft.net> From: Thomas Lamprecht Message-ID: Date: Tue, 7 Apr 2020 10:04:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:75.0) Gecko/20100101 Thunderbird/75.0 MIME-Version: 1.0 In-Reply-To: <20200331.100806.878847626011762877.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/31/20 7:08 PM, David Miller wrote: > From: Bruno Meneguele > Date: Tue, 31 Mar 2020 10:06:30 -0300 > >> A testing message was brought by 13d0f7b814d9 ("net/bpfilter: fix dprintf >> usage for /dev/kmsg") but should've been deleted before patch submission. >> Although it doesn't cause any harm to the code or functionality itself, it's >> totally unpleasant to have it displayed on every loop iteration with no real >> use case. Thus remove it unconditionally. >> >> Fixes: 13d0f7b814d9 ("net/bpfilter: fix dprintf usage for /dev/kmsg") >> Signed-off-by: Bruno Meneguele > > Applied, thanks. > As the commit this fixes was included in a stable release (at least 5.4.29[0], I did not checked others - sorry) it could make sense to backport this also to the 5.4 stable tree? Per documentation[1], I checked the netdev and Greg's queues, but did not found it to be included anywhere yet. I hope I handled this request somewhat correctly, please tell me if I should propose the backported patch more directly to the respective stable list. As is, the patch[2] applies fine here on top of 5.4.30. cheers, Thomas [0]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.4.y&id=712c39d9319a864b74b44fd03b0e083afa2d8af2 [1]: https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html#q-how-can-i-tell-what-patches-are-queued-up-for-backporting-to-the-various-stable-releases [2]: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/patch/?id=41c55ea6c2a7ca4c663eeec05bdf54f4e2419699