Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4137374ybb; Tue, 7 Apr 2020 01:15:56 -0700 (PDT) X-Google-Smtp-Source: APiQypL5L5dsQJl7A9yelU2/M84/Z4r9jBqr/HrMwBg68hlcrnSjdmP9F1PbakXwQtMWMY56zh6B X-Received: by 2002:a05:6830:1e79:: with SMTP id m25mr608942otr.36.1586247356280; Tue, 07 Apr 2020 01:15:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586247356; cv=none; d=google.com; s=arc-20160816; b=uEcPWRyXdQE0RILUFU2ssxR0HrphJkHTqi8UcubyRkgYXPHgZHIh2fz81WTA932lgf +RmPaWCToRF4AFMiHwskh2gjYCNNIQN1LmhLBz4VEgQUG5EDKcGi8JIgkJ7NxUlaS6iw fz2ydH3HyjuOVKPdn1JMaMi6kehnTZfAEg6Qm9U5WFPngsv1AXUs+HioGb8xpX0LWYAS atWyK99i68AIFctq7KLq8jdSzojkhNkAfVOpNPgDcZVOq0+SG5tZ3jE9tKnkfHd91fKT xzYbEJZZ433BkNnWgAyufxRJ9aSAfQTkVBpOIYX6ZW8DtZHgN84VYd4VsBgJv2JtetlQ xbQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=+nEFRV7gqrg+aq4arRmTZEAYTTy4naZJpHzjcWAuFyo=; b=v6ZIHPKGNXsSQ7Chh0icTwh9RSbwlz0PgzEH9i+FTJju7Truls5j2M28wZSUi6DYIS qYuYAYn12JLttGUnBtd77foBYqskotRZcD3bNrG57767ugJiodd7oarW6e+44y5szzLA dkYgannWJgk38jH80+bEMMy4wy0BKrxTUy65joEjm343tR32dbn87fl8F9EsvUIUP36l +czxFoN2lHHx9clLx+sQyWKBezeE3NLnSn701aZyj1GTuhq69cCpcfYwTzGvQ6M2kqyO G4TPtTDreZ4Z34d3tV5XMEemx+b9oJMIJIpScEYc2IPJowc/OIUh3l7Xzl6k7oZwTm14 BUCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sEPhxcAf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h10si923416otm.153.2020.04.07.01.15.44; Tue, 07 Apr 2020 01:15:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sEPhxcAf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727192AbgDGIPL (ORCPT + 99 others); Tue, 7 Apr 2020 04:15:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:45178 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726393AbgDGIPK (ORCPT ); Tue, 7 Apr 2020 04:15:10 -0400 Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AB04120801; Tue, 7 Apr 2020 08:15:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586247309; bh=dEmA4cuG8bN53q2x0ul8u7PDRTuM3LEq8qspwvwBuBs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=sEPhxcAf0XJ1a/fHnUbFabJSW9BJgkWw4M+iMRNsfNAGz9pwcvkddldUVoXII9uYX DwpG9K6MA9N81tQfTVll8qFqqcFLU4IAVX+LbbjyLsOkhWunUJUJGSOkldcLUzNyCb +W1xJXUSztqeWWqOXN1G6jsKXGr5QKksADzEDQWU= Received: by mail-vk1-f170.google.com with SMTP id q7so49897vkb.9; Tue, 07 Apr 2020 01:15:09 -0700 (PDT) X-Gm-Message-State: AGi0PubOEp3yAodyOl46Q+Hr5HvCFljR+cWpjzfuKuwjiVme3TAM90yY 2Abm1aiSK3Y7ddrXefyQQDW+x8nUpK0ljDrvt4Q= X-Received: by 2002:ac5:cbd5:: with SMTP id h21mr587035vkn.60.1586247308681; Tue, 07 Apr 2020 01:15:08 -0700 (PDT) MIME-Version: 1.0 References: <20200402000002.7442-1-mcgrof@kernel.org> <20200402000002.7442-3-mcgrof@kernel.org> <3640b16b-abda-5160-301a-6a0ee67365b4@acm.org> <75aa4cff-1b90-ebd4-17a4-c1cb6d390b30@acm.org> <87d08lj7l6.fsf@suse.de> <20200406151907.GD11244@42.do-not-panic.com> In-Reply-To: <20200406151907.GD11244@42.do-not-panic.com> From: Luis Chamberlain Date: Tue, 7 Apr 2020 02:15:03 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 2/3] blktrace: fix debugfs use after free To: Nicolai Stange Cc: Bart Van Assche , Eric Sandeen , Jens Axboe , Al Viro , Greg Kroah-Hartman , Steven Rostedt , Ingo Molnar , Jan Kara , Ming Lei , Michal Hocko , linux-block@vger.kernel.org, Linux FS Devel , "linux-kernel@vger.kernel.org" , Omar Sandoval , Hannes Reinecke , Michal Hocko , syzbot+603294af2d01acfdd6da@syzkaller.appspotmail.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 6, 2020 at 9:19 AM Luis Chamberlain wrote: > > On Mon, Apr 06, 2020 at 11:18:13AM +0200, Nicolai Stange wrote: > > Bart Van Assche writes: > > > So I'd suggest to drop patch [3/3] from this series and modify this > > patch [2/3] here to move the blk_q_debugfs_unregister(q) invocation from > > __blk_release_queue() to blk_unregister_queue() instead. > > I'll take a stab. That didn't work. I'll look for alternatives. Luis