Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4153841ybb; Tue, 7 Apr 2020 01:41:36 -0700 (PDT) X-Google-Smtp-Source: APiQypIzWBiNcbZ9IXYImEG9YKeszASKEh7bmWqBY/0H5jJKpDzN5SfUn4PYPCD0nInw/8sCYME2 X-Received: by 2002:aca:5354:: with SMTP id h81mr819722oib.164.1586248896269; Tue, 07 Apr 2020 01:41:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586248896; cv=none; d=google.com; s=arc-20160816; b=RJ38oQ59yl7R/+nF4WU9YstWI4Z2OKIIjo33+lTZ4j1gwXOLDf8YXhJdnlhMiGwvuE rZn90GAJYAH4EBSoChW5Xsc41UruSkMjG3okjXHiL995VbbfXfNWL2Wu2sq3jWvcOHw5 t9sGJjzKsa0XtLyzdDakPO78g4vjYgrwOCik/qSLjOX4YBA5jNrN7rl/H3p+zBX9uyOw ZwdGayI66dF02ovjhsNzRROr+tS9ZXt1iDIeP0Lfw0l4loWKR/N5RXenkwVhvk3F30Th tZsTVlzHhALN3rSwKJoyXmq1pYJ8HXcoYWUUmiGkwLf91BL9o0S0ltRr+0kMzEkCyI+E uw7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=kB4OcN1ZXWgtnJSQ36/P8ZW281mvf5XOO99z181MWZc=; b=zMkyI6DWmj4JKVJ1RpvY8RZ88H7+4dgKf6s+tAU/zghjaja0PduGdErklmjn61fMH+ F/XmjvCUbl2gpOPhnnaZWgXezcPARUhjMLFy513Z++skMcJxVo5aRtD+6C9SoUbOS7cS P85hJbdnKEwf9WgaSzC4wASSL7EXcMa9m+mxV8q1A1bcWGeb3maD/tZdBf09WXgWyQZ8 1V/tPUyQY+rEpkKqjRJ+hrV8Zxe9rnoE0goJHWxIbv/Z9e41lW1d28dV1F/OTahy/UGV wtkkk6HHRMZNwOzrT8cJhR8CvlGuTMWH/xErqcNYBMY+pKIg/qvuA6c7AKK/YHGQ7qnJ TCIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l22si944766otd.53.2020.04.07.01.41.24; Tue, 07 Apr 2020 01:41:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726720AbgDGIkx (ORCPT + 99 others); Tue, 7 Apr 2020 04:40:53 -0400 Received: from elvis.franken.de ([193.175.24.41]:56924 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725883AbgDGIkx (ORCPT ); Tue, 7 Apr 2020 04:40:53 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jLjml-000722-00; Tue, 07 Apr 2020 10:40:43 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 6325EC021C; Tue, 7 Apr 2020 10:40:34 +0200 (CEST) Date: Tue, 7 Apr 2020 10:40:34 +0200 From: Thomas Bogendoerfer To: maobibo Cc: Jiaxun Yang , Huacai Chen , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/39] MIPS: loongson64: Add header files path prefix Message-ID: <20200407084034.GA5688@alpha.franken.de> References: <1585557531-18849-1-git-send-email-maobibo@loongson.cn> <6be02099-4cbe-078b-4b2a-a80d3ed6237a@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6be02099-4cbe-078b-4b2a-a80d3ed6237a@loongson.cn> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 01, 2020 at 05:03:40PM +0800, maobibo wrote: > how about adding dir arch/mips/include/asm/loongson64/mach and add > common header files on it, headers with platform itself keep unchanged? > By so, the patch size will be smaller like this. > > > Thomas, > what is your option? that looks much nicer. There is the config option HAVE_MACH_HEAD_FILES, which looks unused in your new patch. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]