Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4170441ybb; Tue, 7 Apr 2020 02:07:39 -0700 (PDT) X-Google-Smtp-Source: APiQypLab1LLYvgzERhZGAiTbk7ZAGhQiaeH5YFloYcH7gt3O3Lpci51VtOvIMbDtIsiTNkdZgwP X-Received: by 2002:a9d:6452:: with SMTP id m18mr717650otl.51.1586250459089; Tue, 07 Apr 2020 02:07:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586250459; cv=none; d=google.com; s=arc-20160816; b=vWNwucrqWG/6B9HZBL/fF0ON5M9Y809GOJ8N3sZL7XKJsqaYmoQnNxEeStLS4onX3/ 2mRo/Cisq9lreuw2+aAuTntSVPzCnSpjW0tWzb7syOz4VyuUS03vfpK66GH8Hsgh5AJ6 Vodab77wC93JUxrOUmq+up8IcymDjXwanWa1X8T9fB0UunwTt4UVsNat5oOa/85W5Cfx lFdsC1kApXfQQySshTSGsu19f9xUqSQsN0aFrCer7Xm3TuQyNJM96o8AbbABBhlDVSvO PZ/jSKikX0hJ6NZQ6g8Kh8hXgJ4jvEqRF6HCJdXIMAPqyHFpuQp0QjYM5PqJEVMqlPh4 kKUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=7lJs52G0YLjEzEzejMYH9UUjmcEYfwNSFVNEz80aPhk=; b=J3H/wH8l4a6QZ7IiSULX/fPevwvN19Lvwm2ehYJNpMvp4cd4VCgBjn991Xxm+WmL7p ssIj8EY2CZrdbMtROyfPkZnCQbZ3LlgnCqddOGxqXMpEL+KaB0iu1PKlz1ZNP4jmQTcq VNTS00Hpaaj8whee2GVE5ZTXjrwhawLAiMGjv/smGpx/9HI1uvGHsrds/FWpNYWydyuL h6J6i4ORWoyqb8gmnqAlPnanY+t7awKBvq2g/V/nmQIRQMj3ti4M3ackjaIibpT2fnTm iTfy4B0MnPKwOlblfpLwrCRQAHY2OIybQ+oowxNoZxAcwEqeGer+o4gahZphMxvQV4Ul T9zQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j26si1065690otk.98.2020.04.07.02.07.26; Tue, 07 Apr 2020 02:07:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726767AbgDGJGx (ORCPT + 99 others); Tue, 7 Apr 2020 05:06:53 -0400 Received: from mx0a-00128a01.pphosted.com ([148.163.135.77]:27120 "EHLO mx0a-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725817AbgDGJGw (ORCPT ); Tue, 7 Apr 2020 05:06:52 -0400 Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03794QAO022400; Tue, 7 Apr 2020 05:06:10 -0400 Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com with ESMTP id 306m36a31s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Apr 2020 05:06:10 -0400 Received: from ASHBMBX8.ad.analog.com (ashbmbx8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 037968rS018092 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=FAIL); Tue, 7 Apr 2020 05:06:08 -0400 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1779.2; Tue, 7 Apr 2020 05:06:07 -0400 Received: from zeus.spd.analog.com (10.64.82.11) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.1.1779.2 via Frontend Transport; Tue, 7 Apr 2020 05:06:07 -0400 Received: from localhost.localdomain ([10.48.65.12]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 03795tM0008769; Tue, 7 Apr 2020 05:05:56 -0400 From: Bogdan Togorean To: CC: Bogdan Togorean , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Tomi Valkeinen , Wolfram Sang , Matt Redfearn , Rob Clark , Sam Ravnborg , Lars-Peter Clausen , Subject: [RESEND] drm: bridge: adv7511: Fix low refresh rate register for ADV7533/5 Date: Tue, 7 Apr 2020 12:04:55 +0300 Message-ID: <20200407090457.24493-1-bogdan.togorean@analog.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-ADIRoutedOnPrem: True X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676 definitions=2020-04-07_01:2020-04-07,2020-04-07 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 phishscore=0 mlxscore=0 mlxlogscore=787 suspectscore=1 spamscore=0 clxscore=1011 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004070077 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For ADV7533 and ADV7535 low refresh rate is selected using bits [3:2] of 0x4a main register. So depending on ADV model write 0xfb or 0x4a register. Fixes: 9c8af882bf12: ("drm: Add adv7511 encoder driver") Signed-off-by: Bogdan Togorean --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 87b58c1acff4..2a8fd2b27f0d 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -756,8 +756,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511, else low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE; - regmap_update_bits(adv7511->regmap, 0xfb, - 0x6, low_refresh_rate << 1); + if (adv7511->type == ADV7511) + regmap_update_bits(adv7511->regmap, 0xfb, + 0x6, low_refresh_rate << 1); + else + regmap_update_bits(adv7511->regmap, 0x4a, + 0xc, low_refresh_rate << 2); + regmap_update_bits(adv7511->regmap, 0x17, 0x60, (vsync_polarity << 6) | (hsync_polarity << 5)); -- 2.17.1