Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 7 Apr 2020 06:05:09 -0400 (EDT)
From:   Vladis Dronov <vdronov@redhat.com>
To:     Andrea Righi <andrea.righi@canonical.com>
Cc:     Piotr Morgwai =?utf-8?Q?Kotarbi=C5=84ski?= <morgwai@morgwai.pl>,
        Colin Ian King <colin.king@canonical.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Message-ID: <1493646639.21012930.1586253909001.JavaMail.zimbra@redhat.com>
In-Reply-To: <20200407093422.GD3665@xps-13>
References: <20200309172238.GJ267906@xps-13> <1196893766.20531178.1585920854778.JavaMail.zimbra@redhat.com> <20200407093422.GD3665@xps-13>
Subject: Re: [PATCH v2] ptp: free ptp clock properly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Thread-Topic: free ptp clock properly
Thread-Index: WLuFyIwSVbLAUz+GYlxwZs1rVfBFIw==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello,

----- Original Message -----
> From: "Andrea Righi" <andrea.righi@canonical.com>
> To: "Vladis Dronov" <vdronov@redhat.com>
> Cc: "Piotr Morgwai Kotarbi=C5=84ski" <morgwai@morgwai.pl>, "Colin Ian Kin=
g" <colin.king@canonical.com>, "Richard Cochran"
> <richardcochran@gmail.com>, "David S. Miller" <davem@davemloft.net>, netd=
ev@vger.kernel.org,
> linux-kernel@vger.kernel.org
> Sent: Tuesday, April 7, 2020 11:34:22 AM
> Subject: Re: [PATCH v2] ptp: free ptp clock properly
>=20
> On Fri, Apr 03, 2020 at 09:34:14AM -0400, Vladis Dronov wrote:
> > Hello, Andrea, Colin, all,
> >=20
> > This fix is really not needed, as its creation is based on the assumpti=
on
> > that the Ubuntu kernel 5.3.0-40-generic has the upstream commit
> > 75718584cb3c,
> > which is the real fix to this crash.
> >=20
> > > > > I would guess that a kernel in question (5.3.0-40-generic) has th=
e
> > > > > commit
> > > > > a33121e5487b but does not have the commit 75718584cb3c, which sho=
uld
> > > > > be
> > > > > exactly fixing a docking station disconnect crash. Could you plea=
se,
> > > > > check this?
> > > >
> > > > Unfortunately the kernel in question already has 75718584cb3c:
> > > > https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/=
bionic/commit/?h=3Dhwe&id=3Dc71b774732f997ef38ed7bd62e73891a01f2bbfe
> >=20
> > Apologies, but the assumption above is not correct, 5.3.0-40-generic do=
es
> > not have 75718584cb3c. If it had 75718584cb3c it would be a fix and the
> > ptp-related
> > crash (described in https://bugs.launchpad.net/bugs/1864754) would not
> > happen.
> >=20
> > This way
> > https://lists.ubuntu.com/archives/kernel-team/2020-March/108562.html fi=
x
> > is not really needed.
>=20
> Hi Vladis,
>=20
> for the records, I repeated the tests with a lot of help from the bug
> reporter (Morgwai, added in cc), this time making sure we were using the
> same kernels.
>=20
> I confirm that my fix is not really needed as you correctly pointed out.
> Thanks for looking into this and sorry for the noise! :)

Hei, great! Thank you for updating. I'm happy this situation has resolved
properly!

>=20
> -Andrea
>=20

Best regards,
Vladis Dronov | Red Hat, Inc. | The Core Kernel | Senior Software Engineer