Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751397AbWBZWac (ORCPT ); Sun, 26 Feb 2006 17:30:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751362AbWBZWac (ORCPT ); Sun, 26 Feb 2006 17:30:32 -0500 Received: from natblindhugh.rzone.de ([81.169.145.175]:45014 "EHLO natblindhugh.rzone.de") by vger.kernel.org with ESMTP id S1751209AbWBZWab convert rfc822-to-8bit (ORCPT ); Sun, 26 Feb 2006 17:30:31 -0500 From: Wolfgang Hoffmann Reply-To: woho@woho.de To: Stephen Hemminger Subject: Re: [PATCH] Revert sky2 to 0.13a Date: Sun, 26 Feb 2006 23:31:47 +0100 User-Agent: KMail/1.8 Cc: pomac@vapor.com, Carl-Daniel Hailfinger , Jeff Garzik , netdev@vger.kernel.org, Pavel Volkovitskiy , Linux Kernel Mailing List References: <4400FC28.1060705@gmx.net> <1140966011.22812.2.camel@localhost> <200602261913.36308.woho@woho.de> In-Reply-To: <200602261913.36308.woho@woho.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <200602262331.47750.woho@woho.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1355 Lines: 34 On Sunday 26 February 2006 19:13, Wolfgang Hoffmann wrote: > Ok, I did some reading and just started a git bisect. I didn't find hints > on how to bisect if I'm only interested in changes to sky2.[ch], so I'm > taking the full kernel tree and skip testing those bisect steps that didn't > change sky2.[ch]. > > Looking at Carl-Daniels 0.13a and Stephens patch against 0.15 in this > thread, I'll patch each bisect step such that sky2_poll() has > > ???????sky2_write32(hw, STAT_CTRL, SC_STAT_CLR_IRQ); > ???????if (sky2_read8(hw, STAT_LEV_TIMER_CTRL) == TIM_START) { > ???????????????sky2_write8(hw, STAT_LEV_TIMER_CTRL, TIM_STOP); > ???????????????sky2_write8(hw, STAT_LEV_TIMER_CTRL, TIM_START); > ????????} > > after exit_loop. Is that ok? > > I'll report as soon as I have results. Bisect done: 4d52b48b43d0d1d5959fa722ee0046e3542e5e1b is first bad commit [PATCH] sky2: support msi interrupt (revised) Reverting this commit in git head seems to work, at least the driver builds and loads. Is that sane? I'm currently testing this (without any further modifications), let's see if it hangs or not. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/