Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4286527ybb; Tue, 7 Apr 2020 04:36:25 -0700 (PDT) X-Google-Smtp-Source: APiQypLRHzDZCUAS5y722sgbigMG+vumk1Jn/uDHfuDiAaCSJR5q7pm7EuX12KyM4Z+94Xzn1d0A X-Received: by 2002:aca:4d8:: with SMTP id 207mr1239924oie.70.1586259385042; Tue, 07 Apr 2020 04:36:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586259385; cv=none; d=google.com; s=arc-20160816; b=sC3Tvp8NGNe9LK63OWdQtGgO8uTerJEmCr/4c4pCs4u7dhLj7PyKGR9iJRwWpnOnG2 vo2vq5xdW+WwEfekiCgc43QAH5iF5JKzD0zPe1tgu3iwoqdqMy2ZnEZ69qzxclUYyuG3 /DKxe8YbyI4W1h7mUPx7SMBfZ26oUDNLpMgQNe2zc7xY/dJMy7CUcgBD6AaUJbgVGGCP OjuUkRRNuK9pU2qcKOA1l4Zlh8NhHrRjlUrtJ/PseuDKV6dS3jyjwHeFPiRKL5HUYyl0 zp1xcQP56R1WUihFwAE6TfEqlqTfDhTu1mwl7K+fjJALaQVg3dynPBDyibu1lmTwG+OD da6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:from:references:cc:to:subject :dkim-signature; bh=qpjtsSlf5dg8bytaCIXN5nNpvbIU9jzXLRpTtfMMYBI=; b=BqdhwzMX+EPkloFfsqucSTZJo+KXAEYbEmrqoTuSCj2h8iszgvwHsSGbyZa9FWmK2g yd70PUNuIgkPb298uLUuWjqgGKqApfU9llIKLdTu6qOTIXenlxKbFWUjzn2noLgeEwPg W0kitE/QiiuC32Z5hGzXDX3H/rZwrXRCvgRkp9eeBdL0r+KrGnJ7Ccc2oaC6hF5YbNRt Eawz8vYCowHMQiQAd89muGrUcpAATk7nfVj1gTt32fmc6sBiyBBxSaI2WEOdZ9Wmvvlj ioNz/fRce0budZ0OYxJHhpkG9/gBvG7HtdU/Ul5F9CrEZCQ1W/WZrNj/d6Kio7Lf0EDX Gqcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VC7ZWZ2s; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s1si1133266otp.194.2020.04.07.04.36.13; Tue, 07 Apr 2020 04:36:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VC7ZWZ2s; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728486AbgDGLfK (ORCPT + 99 others); Tue, 7 Apr 2020 07:35:10 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:47037 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728075AbgDGLfK (ORCPT ); Tue, 7 Apr 2020 07:35:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586259308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qpjtsSlf5dg8bytaCIXN5nNpvbIU9jzXLRpTtfMMYBI=; b=VC7ZWZ2shbpJnWNo4bw4u3/4yfjsQqvwC2i6C2lQCPzATQY0y6Ev5KPY1dnpIJpx5NQqJp 4G6zHU9xl68sGSiEzUJSA79aVF4X0vHyPJ6z80pEwyWzBEdefM3WXrHKQW7eFskTQTeyxQ 1zHBxgsikqRHOd7gPFEaXbbsJk9JPPY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-413-3fVkbs98M8egPD6ZcYNwag-1; Tue, 07 Apr 2020 07:35:06 -0400 X-MC-Unique: 3fVkbs98M8egPD6ZcYNwag-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6B150107ACC4; Tue, 7 Apr 2020 11:35:04 +0000 (UTC) Received: from [10.36.114.167] (ovpn-114-167.ams2.redhat.com [10.36.114.167]) by smtp.corp.redhat.com (Postfix) with ESMTP id B5EEDC0D89; Tue, 7 Apr 2020 11:35:01 +0000 (UTC) Subject: Re: [PATCH v2 2/5] KVM: s390: vsie: Fix delivery of addressing exceptions To: Claudio Imbrenda Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Vasily Gorbik , Heiko Carstens , Cornelia Huck , Janosch Frank , Christian Borntraeger , stable@vger.kernel.org References: <20200403153050.20569-1-david@redhat.com> <20200403153050.20569-3-david@redhat.com> <20200407130013.2898fb57@p-imbrenda> From: David Hildenbrand Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= mQINBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABtCREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT6JAlgEEwEIAEICGwMFCQlmAYAGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl3pImkCGQEACgkQTd4Q 9wD/g1o+VA//SFvIHUAvul05u6wKv/pIR6aICPdpF9EIgEU448g+7FfDgQwcEny1pbEzAmiw zAXIQ9H0NZh96lcq+yDLtONnXk/bEYWHHUA014A1wqcYNRY8RvY1+eVHb0uu0KYQoXkzvu+s Dncuguk470XPnscL27hs8PgOP6QjG4jt75K2LfZ0eAqTOUCZTJxA8A7E9+XTYuU0hs7QVrWJ jQdFxQbRMrYz7uP8KmTK9/Cnvqehgl4EzyRaZppshruKMeyheBgvgJd5On1wWq4ZUV5PFM4x II3QbD3EJfWbaJMR55jI9dMFa+vK7MFz3rhWOkEx/QR959lfdRSTXdxs8V3zDvChcmRVGN8U Vo93d1YNtWnA9w6oCW1dnDZ4kgQZZSBIjp6iHcA08apzh7DPi08jL7M9UQByeYGr8KuR4i6e RZI6xhlZerUScVzn35ONwOC91VdYiQgjemiVLq1WDDZ3B7DIzUZ4RQTOaIWdtXBWb8zWakt/ ztGhsx0e39Gvt3391O1PgcA7ilhvqrBPemJrlb9xSPPRbaNAW39P8ws/UJnzSJqnHMVxbRZC Am4add/SM+OCP0w3xYss1jy9T+XdZa0lhUvJfLy7tNcjVG/sxkBXOaSC24MFPuwnoC9WvCVQ ZBxouph3kqc4Dt5X1EeXVLeba+466P1fe1rC8MbcwDkoUo65Ag0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAGJAiUEGAECAA8FAlXLn5ECGwwFCQlmAYAACgkQTd4Q 9wD/g1qA6w/+M+ggFv+JdVsz5+ZIc6MSyGUozASX+bmIuPeIecc9UsFRatc91LuJCKMkD9Uv GOcWSeFpLrSGRQ1Z7EMzFVU//qVs6uzhsNk0RYMyS0B6oloW3FpyQ+zOVylFWQCzoyyf227y GW8HnXunJSC+4PtlL2AY4yZjAVAPLK2l6mhgClVXTQ/S7cBoTQKP+jvVJOoYkpnFxWE9pn4t H5QIFk7Ip8TKr5k3fXVWk4lnUi9MTF/5L/mWqdyIO1s7cjharQCstfWCzWrVeVctpVoDfJWp 4LwTuQ5yEM2KcPeElLg5fR7WB2zH97oI6/Ko2DlovmfQqXh9xWozQt0iGy5tWzh6I0JrlcxJ ileZWLccC4XKD1037Hy2FLAjzfoWgwBLA6ULu0exOOdIa58H4PsXtkFPrUF980EEibUp0zFz GotRVekFAceUaRvAj7dh76cToeZkfsjAvBVb4COXuhgX6N4pofgNkW2AtgYu1nUsPAo+NftU CxrhjHtLn4QEBpkbErnXQyMjHpIatlYGutVMS91XTQXYydCh5crMPs7hYVsvnmGHIaB9ZMfB njnuI31KBiLUks+paRkHQlFcgS2N3gkRBzH7xSZ+t7Re3jvXdXEzKBbQ+dC3lpJB0wPnyMcX FOTT3aZT7IgePkt5iC/BKBk3hqKteTnJFeVIT7EC+a6YUFg= Organization: Red Hat GmbH Message-ID: <7345a3fa-d790-5e9c-dbc0-58cfd1b6101e@redhat.com> Date: Tue, 7 Apr 2020 13:35:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200407130013.2898fb57@p-imbrenda> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07.04.20 13:00, Claudio Imbrenda wrote: > On Fri, 3 Apr 2020 17:30:47 +0200 > David Hildenbrand wrote: > >> Whenever we get an -EFAULT, we failed to read in guest 2 physical >> address space. Such addressing exceptions are reported via a program >> intercept to the nested hypervisor. >> >> We faked the intercept, we have to return to guest 2. Instead, right >> now we would be returning -EFAULT from the intercept handler, >> eventually crashing the VM. >> >> Addressing exceptions can only happen if the g2->g3 page tables >> reference invalid g2 addresses (say, either a table or the final page >> is not accessible - so something that basically never happens in sane >> environments. >> >> Identified by manual code inspection. >> >> Fixes: a3508fbe9dc6 ("KVM: s390: vsie: initial support for nested >> virtualization") Cc: # v4.8+ >> Signed-off-by: David Hildenbrand >> --- >> arch/s390/kvm/vsie.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c >> index 076090f9e666..4f6c22d72072 100644 >> --- a/arch/s390/kvm/vsie.c >> +++ b/arch/s390/kvm/vsie.c >> @@ -1202,6 +1202,7 @@ static int vsie_run(struct kvm_vcpu *vcpu, >> struct vsie_page *vsie_page) scb_s->iprcc = PGM_ADDRESSING; >> scb_s->pgmilc = 4; >> scb_s->gpsw.addr = __rewind_psw(scb_s->gpsw, 4); >> + rc = 1; >> } >> return rc; >> } > > so, the reason why we never noticed this issue before is simply that > nobody tried running a misbehaving nested guest? Yes, actually, a misbehaving nested hypervisor. > > Reviewed-by: Claudio Imbrenda > Thanks! -- Thanks, David / dhildenb