Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4349058ybb; Tue, 7 Apr 2020 05:54:16 -0700 (PDT) X-Google-Smtp-Source: APiQypLdh0NSRjXj2dEFSioNXLONJlFEC3HAVrak+bl8aRdsA0IkGaC4RFw0g4o2UbVGzXylk8Gc X-Received: by 2002:aca:4986:: with SMTP id w128mr1486251oia.46.1586264056371; Tue, 07 Apr 2020 05:54:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586264056; cv=none; d=google.com; s=arc-20160816; b=PHnaYhH8nq1WZvUOE5f6+glbGIET82cy9D2j5mQu8e3S+YD2DZamUJzxRyFtwld7GR u7tX+PoskOpYQvjoHwC5A/3PwvlmgewvZ7PRI/ylcQ9nbnAsMGgdgXBSATqVG1EtPBaa eQ+e7d+6NrOr34esmZcfpK8ws4C25Q7jshg/nrD/oMQ+LlWgaI5F1IhxUNr2BavkvrRR RgXV6CpcdOAwOaa4Dkov0JbvDBeL59vIV6XR/wuwb/yTFKkpS73qxWBs7/fNp+bfeuuE d4GukPArASdPrYJ8LKLWh6vEZN94b0JVNC++vGbnIZIbtgTG06FqOx0xS81CH2+7IQMX O1NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=aepFZdwloQbse+rSl/5D2c4bJ4JNDDeUhJa+t/r8qFA=; b=lGsPUI4oBaeVBchwVj8E32lYfApDl6zCiXP7d9WE2Q9owFEmwYX/5iEeGvCa1jSRY1 ezJv+Up6Ig2JfoUuaTR/lHtR0kKj1NndjurvswRATAlIA1nL0AUZYCnddDoXbx5qVQox 7lJ35CHZNnUO7kILts6z0yO20IcRZd8CqPO7Mlgp0dk9UFvZ/kv497lDe2Ip+3XCMkmm kkwAIRn4L6g2EjZLlddzVmUiYdJKv3H1limU4eIFEJxCbDdR8x5uQUQkcgVy7y38lJlk D2Ms19ZK8Gc0NHwNra2rC1dJpi5vPsEmPR8kFJbJg1J+FNBuqMXOsCxjmtEHphSEoaK/ ZumA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="uK6rpj/I"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c20si1100944otn.247.2020.04.07.05.54.03; Tue, 07 Apr 2020 05:54:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="uK6rpj/I"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728556AbgDGMxb (ORCPT + 99 others); Tue, 7 Apr 2020 08:53:31 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:35490 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728146AbgDGMxb (ORCPT ); Tue, 7 Apr 2020 08:53:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=aepFZdwloQbse+rSl/5D2c4bJ4JNDDeUhJa+t/r8qFA=; b=uK6rpj/IHqJZzPhVKilSgGk3b3 cgvFBQf043PVyfJcdz7h+yDis3442KITV+QoShsc1gs4mHWbm8Ot+zPHwreNLvPmPQtnDIJ56n4Ze ZGY3ooICNxHSPbrbreMshLmswIDzvRwT7meyvmL44Zut8KCAgSWWArp/nBX+s3xyk6c8yILWgBP+z XoUZjUTe/sJ0rHYtrNM/sB3gZ7cfplnrAGRlzxFsK4oXu/iVq7OGfAXbUSaufOYutWgrhejtbdg4+ viNj+ljul8fKbdl0LBRToqIzQXJqwwgSOvM4sCSoxfdEeVCKurwBNaRiu/fU74wUuMUwZlpA9NbID hijjj5sA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLnjJ-0007jV-ER; Tue, 07 Apr 2020 12:53:25 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id AC0383010C8; Tue, 7 Apr 2020 14:53:23 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 96A252B907A90; Tue, 7 Apr 2020 14:53:23 +0200 (CEST) Date: Tue, 7 Apr 2020 14:53:23 +0200 From: Peter Zijlstra To: Alexandre Chartre Cc: x86@kernel.org, linux-kernel@vger.kernel.org, jpoimboe@redhat.com, jthierry@redhat.com, tglx@linutronix.de Subject: Re: [PATCH V2 1/9] objtool: Introduce HINT_RET_OFFSET Message-ID: <20200407125323.GY20730@hirez.programming.kicks-ass.net> References: <20200407073142.20659-1-alexandre.chartre@oracle.com> <20200407073142.20659-2-alexandre.chartre@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200407073142.20659-2-alexandre.chartre@oracle.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 07, 2020 at 09:31:34AM +0200, Alexandre Chartre wrote: > diff --git a/tools/objtool/check.h b/tools/objtool/check.h > index 6d875ca6fce0..7a91497fee7e 100644 > --- a/tools/objtool/check.h > +++ b/tools/objtool/check.h > @@ -33,9 +33,12 @@ struct instruction { > unsigned int len; > enum insn_type type; > unsigned long immediate; > - bool alt_group, dead_end, ignore, hint, save, restore, ignore_alts; > + unsigned int alt_group; ^^ that wants to be in a later patch I'm thinking > + bool dead_end, ignore, ignore_alts; > + bool hint, save, restore; > bool retpoline_safe; > u8 visited; > + u8 ret_offset; > struct symbol *call_dest; > struct instruction *jump_dest; > struct instruction *first_jump_src; > -- > 2.18.2 >