Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RESEND 2/2] drm: bridge: adv7511: Extend list of audio sample
 rates
To:     Bogdan Togorean <bogdan.togorean@analog.com>,
        dri-devel@lists.freedesktop.org
Cc:     jernej.skrabec@siol.net, jonas@kwiboo.se, airlied@linux.ie,
        narmstrong@baylibre.com, linux-kernel@vger.kernel.org,
        alexios.zavras@intel.com, Laurent.pinchart@ideasonboard.com,
        tglx@linutronix.de
From:   Andrzej Hajda <a.hajda@samsung.com>
Message-ID: <6ecea2a4-ba7a-929e-3536-22bbb1a39f40@samsung.com>
Date:   Tue, 7 Apr 2020 17:09:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
        Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200224120155.15510-2-bogdan.togorean@analog.com>
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <20200224120155.15510-1-bogdan.togorean@analog.com>
        <CGME20200224165503eucas1p2a8aea2390c4b0421e99641e0d4183167@eucas1p2.samsung.com>
        <20200224120155.15510-2-bogdan.togorean@analog.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 24.02.2020 13:01, Bogdan Togorean wrote:
> ADV7511 support sample rates up to 192kHz. CTS and N parameters should
> be computed accordingly so this commit extend the list up to maximum
> supported sample rate.
>
> Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> ---
>  drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> index 1e9b128d229b..13e8cee6e827 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> @@ -27,6 +27,18 @@ static void adv7511_calc_cts_n(unsigned int f_tmds, unsigned int fs,
>  	case 48000:
>  		*n = 6144;
>  		break;
> +	case 88200:
> +		*n = 12544;
> +		break;
> +	case 96000:
> +		*n = 12288;
> +		break;
> +	case 176400:
> +		*n = 25088;
> +		break;
> +	case 192000:
> +		*n = 24576;
> +		break;


I would put:

case 32000:
case 48000:
case 96000:
case 192000:
    *n = fs * 128 / 1000;
    break;
case 44100:
case 88200:
case 176400:
    *n = fs * 128 / 900;
    break;

To uncover the magic. Up to you.

Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>


Regards
Andrzej
>  	}
>  
>  	*cts = ((f_tmds * *n) / (128 * fs)) * 1000;