Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Originaldate: Mon Apr 6, 2020 at 9:15 PM
Originalfrom: "Julia Lawall" <julia.lawall@inria.fr>
Original: =?utf-8?q?=0D=0A=0D=0AOn_Fri,_3_Apr_2020,_Alex_Dewar_wrote:
 =0D=0A=0D=0A>_?= =?utf-8?q?Commit_dfd32cad146e_("dma-mapping:_remove_dma
 =5Fzalloc=5Fcohere?= =?utf-8?q?nt()"),_in=0D=0A>_removing_dma=5Fzalloc
 =5Fcoherent()_treewide,_?= =?utf-8?q?inadvertently_removed_the_patch
 =0D=0A>_rule_for_dma=5Falloc=5Fc?=
 =?utf-8?q?oherent(),_leaving_Coccinelle_unable_to_auto-generate=0D=0A>_pa?=
 =?utf-8?q?tches_for_this_case._Fix_this.=0D=0A>=0D=0A>_Fixes:_dfd32cad146?=
 =?utf-8?q?e_("dma-mapping:_remove_dma=5Fzalloc=5Fcoherent()")=0D=0A>_CC:_?=
 =?utf-8?q?Luis_Chamberlain_<mcgrof@kernel.org>=0D=0A>_Signed-off-by:_Alex?=
 =?utf-8?q?_Dewar_<alex.dewar@gmx.co.uk>=0D=0A>_---=0D=0A>__scripts/coccin?=
 =?utf-8?q?elle/api/alloc/zalloc-simple.cocci_|_9_+++++++++=0D=0A>__1_file?=
 =?utf-8?q?_changed,_9_insertions(+)=0D=0A>=0D=0A>_diff_--git_a/scripts/co?=
 =?utf-8?q?ccinelle/api/alloc/zalloc-simple.cocci_b/scripts/coccinelle/api?=
 =?utf-8?q?/alloc/zalloc-simple.cocci=0D=0A>_index_26cda3f48f01..c53aab7fe?=
 =?utf-8?q?096_100644=0D=0A>_---_a/scripts/coccinelle/api/alloc/zalloc-sim?=
 =?utf-8?q?ple.cocci=0D=0A>_+++_b/scripts/coccinelle/api/alloc/zalloc-simp?=
 =?utf-8?q?le.cocci=0D=0A>_@@_-70,6_+70,15_@@_statement_S;=0D=0A>__-_x_=3D?=
 =?utf-8?q?_(T)vmalloc(E1);=0D=0A>__+_x_=3D_(T)vzalloc(E1);=0D=0A>__|=0D?=
 =?utf-8?q?=0A>_+-_x_=3D_dma=5Falloc=5Fcoherent(E2,E1,E3,E4);=0D=0A>_++_x_?=
 =?utf-8?q?=3D_dma=5Falloc=5Fcoherent(E2,E1,E3,E4);=0D=0A=0D=0AHi,=0D=0A?=
 =?utf-8?q?=0D=0AI_don't_understand_the_above_case.__The_before_and_after_?=
 =?utf-8?q?code_seem_to_be=0D=0Athe_same=3F=0D=0A=0D=0Ajulia=0D=0A=0D=0A?=
 =?utf-8?q?=0D=0A>_+|=0D=0A>_+-_x_=3D_(T_*)dma=5Falloc=5Fcoherent(E2,E1,E3?=
 =?utf-8?q?,E4);=0D=0A>_++_x_=3D_dma=5Falloc=5Fcoherent(E2,E1,E3,E4);=0D?=
 =?utf-8?q?=0A>_+|=0D=0A>_+-_x_=3D_(T)dma=5Falloc=5Fcoherent(E2,E1,E3,E4);?=
 =?utf-8?q?=0D=0A>_++_x_=3D_(T)dma=5Falloc=5Fcoherent(E2,E1,E3,E4);=0D=0A>?=
 =?utf-8?q?_+|=0D=0A>__-_x_=3D_kmalloc=5Fnode(E1,E2,E3);=0D=0A>__+_x_=3D_k?=
 =?utf-8?q?zalloc=5Fnode(E1,E2,E3);=0D=0A>__|=0D=0A>_--=0D=0A>_2.26.0=0D?=
 =?utf-8?q?=0A>=0D=0A>=0D=0A?=
In-Reply-To: <alpine.DEB.2.21.2004062115000.10239@hadrien>
Date:   Tue, 07 Apr 2020 16:37:42 +0100
Subject: Re: [PATCH] Coccinelle: zalloc_simple: Fix patch mode for
 dma_alloc_coherent()
From:   "Alex Dewar" <alex.dewar@gmx.co.uk>
To:     "Julia Lawall" <julia.lawall@inria.fr>
Cc:     "Luis Chamberlain" <mcgrof@kernel.org>,
        "Gilles Muller" <Gilles.Muller@lip6.fr>,
        "Nicolas Palix" <nicolas.palix@imag.fr>,
        "Michal Marek" <michal.lkml@markovi.net>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        "Kate Stewart" <kstewart@linuxfoundation.org>,
        "Allison Randal" <allison@lohutok.net>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        <cocci@systeme.lip6.fr>, <linux-kernel@vger.kernel.org>
Message-Id: <C1V35KAVQM0U.2UPMSFF20IXI8@lenovo-laptop>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon Apr 6, 2020 at 9:15 PM, Julia Lawall wrote:
>
>=20
>
>=20
> On Fri, 3 Apr 2020, Alex Dewar wrote:
>
>=20
> > Commit dfd32cad146e ("dma-mapping: remove dma_zalloc_coherent()"), in
> > removing dma_zalloc_coherent() treewide, inadvertently removed the patc=
h
> > rule for dma_alloc_coherent(), leaving Coccinelle unable to auto-genera=
te
> > patches for this case. Fix this.
> >
> > Fixes: dfd32cad146e ("dma-mapping: remove dma_zalloc_coherent()")
> > CC: Luis Chamberlain <mcgrof@kernel.org>
> > Signed-off-by: Alex Dewar <alex.dewar@gmx.co.uk>
> > ---
> >  scripts/coccinelle/api/alloc/zalloc-simple.cocci | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/scripts/coccinelle/api/alloc/zalloc-simple.cocci b/scripts=
/coccinelle/api/alloc/zalloc-simple.cocci
> > index 26cda3f48f01..c53aab7fe096 100644
> > --- a/scripts/coccinelle/api/alloc/zalloc-simple.cocci
> > +++ b/scripts/coccinelle/api/alloc/zalloc-simple.cocci
> > @@ -70,6 +70,15 @@ statement S;
> >  - x =3D (T)vmalloc(E1);
> >  + x =3D (T)vzalloc(E1);
> >  |
> > +- x =3D dma_alloc_coherent(E2,E1,E3,E4);
> > ++ x =3D dma_alloc_coherent(E2,E1,E3,E4);
>
>=20
> Hi,
>
>=20
> I don't understand the above case. The before and after code seem to be
> the same?
>
>=20
> julia
>
>=20
>
>=20
> > +|
> > +- x =3D (T *)dma_alloc_coherent(E2,E1,E3,E4);
> > ++ x =3D dma_alloc_coherent(E2,E1,E3,E4);
> > +|
> > +- x =3D (T)dma_alloc_coherent(E2,E1,E3,E4);
> > ++ x =3D (T)dma_alloc_coherent(E2,E1,E3,E4);
> > +|
> >  - x =3D kmalloc_node(E1,E2,E3);
> >  + x =3D kzalloc_node(E1,E2,E3);
> >  |
> > --
> > 2.26.0
> >
> >
>
>=20
>
>=20