Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 7 Apr 2020 16:50:05 +0100
From:   Alex Dewar <alex.dewar@gmx.co.uk>
To:     Julia Lawall <julia.lawall@inria.fr>
Cc:     Luis Chamberlain <mcgrof@kernel.org>,
        Gilles Muller <Gilles.Muller@lip6.fr>,
        Nicolas Palix <nicolas.palix@imag.fr>,
        Michal Marek <michal.lkml@markovi.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        Allison Randal <allison@lohutok.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Coccinelle: zalloc_simple: Fix patch mode for
 dma_alloc_coherent()
Message-ID: <20200407155005.rdyiu7xqss57rzhq@lenovo-laptop>
References: <20200403173011.65511-1-alex.dewar@gmx.co.uk>
 <alpine.DEB.2.21.2004062115000.10239@hadrien>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.21.2004062115000.10239@hadrien>
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 06, 2020 at 09:15:29PM +0200, Julia Lawall wrote:
>
>
> On Fri, 3 Apr 2020, Alex Dewar wrote:
>
> > Commit dfd32cad146e ("dma-mapping: remove dma_zalloc_coherent()"), in
> > removing dma_zalloc_coherent() treewide, inadvertently removed the pat=
ch
> > rule for dma_alloc_coherent(), leaving Coccinelle unable to auto-gener=
ate
> > patches for this case. Fix this.
> >
> > Fixes: dfd32cad146e ("dma-mapping: remove dma_zalloc_coherent()")
> > CC: Luis Chamberlain <mcgrof@kernel.org>
> > Signed-off-by: Alex Dewar <alex.dewar@gmx.co.uk>
> > ---
> >  scripts/coccinelle/api/alloc/zalloc-simple.cocci | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/scripts/coccinelle/api/alloc/zalloc-simple.cocci b/script=
s/coccinelle/api/alloc/zalloc-simple.cocci
> > index 26cda3f48f01..c53aab7fe096 100644
> > --- a/scripts/coccinelle/api/alloc/zalloc-simple.cocci
> > +++ b/scripts/coccinelle/api/alloc/zalloc-simple.cocci
> > @@ -70,6 +70,15 @@ statement S;
> >  - x =3D (T)vmalloc(E1);
> >  + x =3D (T)vzalloc(E1);
> >  |
> > +- x =3D dma_alloc_coherent(E2,E1,E3,E4);
> > ++ x =3D dma_alloc_coherent(E2,E1,E3,E4);
>
> Hi,
>
> I don't understand the above case.  The before and after code seem to be
> the same?
>
> julia

Hi,

I just wanted to flag up unnecessary calls to memset() after
dma_alloc_coherent() and I wasn't sure how to best express that, though
I'm sure there's a much cleaner way. At the moment the cocci file only
gives warnings for this case, but it would be nice to be able to
autogenerate patches too.

Best,
Alex

>
>
> > +|
> > +- x =3D (T *)dma_alloc_coherent(E2,E1,E3,E4);
> > ++ x =3D dma_alloc_coherent(E2,E1,E3,E4);
> > +|
> > +- x =3D (T)dma_alloc_coherent(E2,E1,E3,E4);
> > ++ x =3D (T)dma_alloc_coherent(E2,E1,E3,E4);
> > +|
> >  - x =3D kmalloc_node(E1,E2,E3);
> >  + x =3D kzalloc_node(E1,E2,E3);
> >  |
> > --
> > 2.26.0
> >
> >