Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 7 Apr 2020 17:02:13 +0100
From:   Alex Dewar <alex.dewar@gmx.co.uk>
To:     Markus Elfring <Markus.Elfring@web.de>
Cc:     Allison Randal <allison@lohutok.net>,
        Arnd Bergmann <arnd@arndb.de>,
        Chaitra Basappa <chaitra.basappa@broadcom.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Himanshu Madhani <hmadhani@marvell.com>,
        "James E. J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Richard Fontana <rfontana@redhat.com>,
        Sathya Prakash <sathya.prakash@broadcom.com>,
        Suganath Prabu Subramani 
        <suganath-prabu.subramani@broadcom.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-scsi@vger.kernel.org, aacraid@microsemi.com,
        MPT-FusionLinux.pdl@broadcom.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: Remove unnecessary calls to memset after
 dma_alloc_coherent
Message-ID: <20200407160213.qh64de6ebrj7qkmx@lenovo-laptop>
References: <e2401a31-e9fd-e849-e27c-6e079f5556d2@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <e2401a31-e9fd-e849-e27c-6e079f5556d2@web.de>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Apr 04, 2020 at 01:14:52PM +0200, Markus Elfring wrote:
> > dma_alloc_coherent() now zeroes memory after allocation, so additional
> > calls to memset() afterwards are unnecessary. Remove them.
>
> I suggest to reconsider the distribution of recipients also for this pat=
ch
> according to the fields =E2=80=9CCc=E2=80=9D and =E2=80=9CTo=E2=80=9D.

Thanks. I'll do this in a v2/RESEND.
>
>
> =E2=80=A6
> > +++ b/drivers/scsi/dpt_i2o.c
> =E2=80=A6
> > @@ -3067,13 +3064,12 @@ static int adpt_i2o_build_sys_table(void)
> >  	sys_tbl_len =3D sizeof(struct i2o_sys_tbl) +	// Header + IOPs
> >  				(hba_count) * sizeof(struct i2o_sys_tbl_entry);
> >
> > -	sys_tbl =3D dma_alloc_coherent(&pHba->pDev->dev,
> > -				sys_tbl_len, &sys_tbl_pa, GFP_KERNEL);
> > +	sys_tbl =3D dma_alloc_coherent(&pHba->pDev->dev, sys_tbl_len,
> > +				     &sys_tbl_pa, GFP_KERNEL);
> >  	if (!sys_tbl) {
> =E2=80=A6
> > +++ b/drivers/scsi/mvsas/mv_init.c
> > @@ -244,28 +244,22 @@ static int mvs_alloc(struct mvs_info *mvi, struc=
t Scsi_Host *shost)
> =E2=80=A6
> > -	mvi->slot =3D dma_alloc_coherent(mvi->dev,
> > -				       sizeof(*mvi->slot) * slot_nr,
> > +	mvi->slot =3D dma_alloc_coherent(mvi->dev, sizeof(*mvi->slot) * slot=
_nr,
> >  				       &mvi->slot_dma, GFP_KERNEL);
> >  	if (!mvi->slot)
> =E2=80=A6
> > +++ b/drivers/scsi/qla2xxx/qla_isr.c
> > @@ -79,7 +79,7 @@ qla24xx_process_abts(struct scsi_qla_host *vha, void=
 *pkt)
> >  	    (uint8_t *)abts, sizeof(*abts));
> >
> >  	rsp_els =3D dma_alloc_coherent(&ha->pdev->dev, sizeof(*rsp_els), &dm=
a,
> > -	    GFP_KERNEL);
> > +				     GFP_KERNEL);
> >  	if (!rsp_els) {
> =E2=80=A6
> > +++ b/drivers/scsi/qla2xxx/qla_mbx.c
> > @@ -4887,15 +4887,13 @@ qla25xx_set_els_cmds_supported(scsi_qla_host_t=
 *vha)
> >  	    "Entered %s.\n", __func__);
> >
> >  	els_cmd_map =3D dma_alloc_coherent(&ha->pdev->dev, ELS_CMD_MAP_SIZE,
> > -	    &els_cmd_map_dma, GFP_KERNEL);
> > +					 &els_cmd_map_dma, GFP_KERNEL);
> >  	if (!els_cmd_map) {
> =E2=80=A6
>
> I find it safer to integrate such source code reformattings by
> another update step which will be separated from the proposed deletion
> of unwanted function calls.

Good point. This whitespace was autoformatted by Coccinelle, probably
due to my bad SmPL skills.

Best,
Alex


>
> Regards,
> Markus