Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4531104ybb; Tue, 7 Apr 2020 09:14:09 -0700 (PDT) X-Google-Smtp-Source: APiQypJ5xKRYGRkKcyXddfbAsOygOLY51bjx58XRNXRjpBiA51Sch3pxmMDH88c8Fm5wmivQMQgo X-Received: by 2002:a9d:22e9:: with SMTP id y96mr2227582ota.217.1586276049151; Tue, 07 Apr 2020 09:14:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586276049; cv=none; d=google.com; s=arc-20160816; b=REy6360QcsnolcPEGNwbwP6I3BJXWFAYeWUdqDQuG/ODWIMqQVDdeCzO3N5RiGXpD/ Ix/MNJwDgFemJOZmU/j+ygS+1EoTY9DDkiAJfTsAbNjukVATZZ0t6O11FqoDgnFvEOB3 3nTcz3YkdPokrHMktd0dxEZMpIp5F0loLYfosSHwfNdtWcdSThPVflldoexjPgdIcXBE WGcKY0ZWoKu1rRgLj0ejTS5l2F1ToPJHhH6P6QcGnJPi4XpjZZFttcdBsq7QROYtY0KA hg6po+lv0dXpkDf+JzfHKSVWcD2XcyqxWTyk2EK2n3KcZYYWrUTfs9/1we0BdbSrENg6 /POw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=0/rdVOr3u5i2ymBgDoIN9hE0ZQznL4f0oL64O+q9Kv8=; b=e9Kz4FznddLVQOWNdPspliXN2wqRovFQpqHKAjVfrLD6jNBQqZ37XNM7fXnqppwxUc bamMb9Xkww5KMjWIgt/mAOL9gy++9+2Fr2kkko2UkKOj4ty67ez2DFGmAzhzGzMxSnL9 swTfYt1aGnw6+1D5KHoZSaibA4wwl+on3y/52kP0CCB7ZqiSIAgwpsk+l9LeeoTeOFdQ pKqLpYiVuR7kT3hRjsBUFnTxmP4jzLf/1Iah/1OaH5FTSG6BUnD19q6jOybitWa++we4 DFpOugf4YjLrpWJW0E+NlcFd95f+CjYyZn7IoKZPRL+p8T871yHk+gDN9pPEhFyMfj8v 2pGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=rQePjIhN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e22si1392989otr.6.2020.04.07.09.13.55; Tue, 07 Apr 2020 09:14:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=rQePjIhN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727865AbgDGQLe (ORCPT + 99 others); Tue, 7 Apr 2020 12:11:34 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:54272 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726776AbgDGQLe (ORCPT ); Tue, 7 Apr 2020 12:11:34 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 48xXTb0gyqz9v16D; Tue, 7 Apr 2020 18:11:31 +0200 (CEST) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=rQePjIhN; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id Ql_PfMohPlTm; Tue, 7 Apr 2020 18:11:31 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 48xXTZ6YCHz9v16C; Tue, 7 Apr 2020 18:11:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1586275890; bh=0/rdVOr3u5i2ymBgDoIN9hE0ZQznL4f0oL64O+q9Kv8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=rQePjIhNGThb9qEO4Fu3PoBYHijoaw3WYYMkhu5bBY/+MoZcwE1oKEJKpRiN1ZTcL 9BoWbCvcFH84Os6RDKM9cVG4Qdzp1VGJkbp7tSqlwyGq/O76EAIz6vI/HUQFrejBaK 4CXn0HHFvmjFW1S4dGnC6zeKXnBVSw7xLYkB2x9s= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 549098B7EE; Tue, 7 Apr 2020 18:11:32 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 6sj_Lv0zLOAp; Tue, 7 Apr 2020 18:11:32 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id C7C0F8B7EC; Tue, 7 Apr 2020 18:11:31 +0200 (CEST) Subject: Re: [PATCH vdsotest] Use vdso wrapper for gettimeofday() To: Nathan Lynch Cc: Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <0eddeeb64c97b8b5ce0abd74e88d2cc0303e49c6.1579090596.git.christophe.leroy@c-s.fr> <871rrzjq5j.fsf@linux.ibm.com> From: Christophe Leroy Message-ID: <1c2c6da1-e10f-d2a8-fc5e-ecf405879df5@c-s.fr> Date: Tue, 7 Apr 2020 18:11:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <871rrzjq5j.fsf@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nathan, Le 16/01/2020 à 17:56, Nathan Lynch a écrit : > Hi Christophe, > > Christophe Leroy writes: >> To properly handle errors returned by gettimeofday(), the >> DO_VDSO_CALL() macro has to be used, otherwise vdsotest >> misinterpret VDSO function return on error. >> >> This has gone unnoticed until now because the powerpc VDSO >> gettimeofday() always succeed, but while porting powerpc to >> generic C VDSO, the following has been encountered: > > Thanks for this, I'll review it soon. > > Can you point me to patches for the powerpc generic vdso work? > I have not seen any update on the vdsotest repository, have you been able to have a look at the patch ? Thanks Christophe