Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4554350ybb; Tue, 7 Apr 2020 09:41:07 -0700 (PDT) X-Google-Smtp-Source: APiQypK+H/RjE4F/+6DUF7xs8TLBZn+vwF04T8cZhbDfV/wpPldXd7LxB7zTWW3c/XGq8xquReTt X-Received: by 2002:a4a:a747:: with SMTP id h7mr2689026oom.2.1586277667213; Tue, 07 Apr 2020 09:41:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586277667; cv=none; d=google.com; s=arc-20160816; b=B+ai/3sH/Fej4XsiZLKXm2hulSaLgIeGea+4QYYGcOn6KmzzD2mYVcOilh03NqXMjr +bfk+c2udQrnQ5gvr58z0ZDwBd0cPEW9YYFZ1jtyFTGfm4z9CynizSPAbqGnUKHzjgfp +GWosboO8wpR6xZpc1LXItv/GZeGvLHlUkHlVPxu410XrneEESB6ElP0rDQ9YMLfj92t eaBeMQmzKcrk5ptbkM98J4B/ctbugFxYoY3gKRatTEcCRt9i4eyU4AaVTfzHBi2FIRlQ ZWDgozPt+FHRAM+3X05WchfvU9XNOZAeA6q7Q1AbbwO3H3yZ4173h5HvwecvRQeXVIb8 lX0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=P5I+br30FVHCv01NRxxKULklJ0e53RbnOMKfDiAD2rY=; b=fN3cwGFFBihO2aHAGs5PY1pyZtqoLE+OTJQxCOehsy8DGtXVu+rsYIn7KTI9GknZXt ObBerQBBoV8I8tFN/WKgP7L5Be3CQyYO7L/jq8vvd83dOlu0uLi0i89uYuXmJE+80YvA q2Q9EgkrR8KfDDxkP5V1UUgEjgL+HHBF4DKARtuOwGTGWfyrFyxLCSxGF0zsJE8WlrkD z/VmSgO1o+qKFRK12gstyR12iQyO1DkgsWcZ0cJl5Pf6BAxNf6NqmyTpWVFu71DYdBrE ChP7LBSVlo+vwp1V56nzrKuBHosX8CzRJaQjpzDyEWxieG3YcnKggZmdW+e7bcmhq6lq xC+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=TPGr2ttT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d21si1392846oof.2.2020.04.07.09.40.54; Tue, 07 Apr 2020 09:41:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=TPGr2ttT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729585AbgDGQjw (ORCPT + 99 others); Tue, 7 Apr 2020 12:39:52 -0400 Received: from mout.gmx.net ([212.227.15.18]:51491 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728503AbgDGQjw (ORCPT ); Tue, 7 Apr 2020 12:39:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1586277582; bh=sgFBcuEhJ09mNWZg34/SHX56SC+2GL9Chr9TTaUeP1s=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=TPGr2ttTPy4K7zMAmRKEHRH79rNJIQOVUG/T7ryGHLGo10c9OK46Z3nfWObswQWTn QVxqsnXaIWsOxeB3hozsxGWyJObUhrDXzmAktAhmFFkXcGbdmqeomxmmENr8plYb6q 9vneJQT1e8U9SdG+3+PIx5UrvTmIu+8fwaefyzNc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([83.52.229.196]) by mail.gmx.com (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1M8ygO-1jPisi2mgw-006At5; Tue, 07 Apr 2020 18:39:42 +0200 From: Oscar Carter To: Forest Bond , Greg Kroah-Hartman Cc: Oscar Carter , Malcolm Priestley , Dan Carpenter , Quentin Deslandes , Amir Mahdi Ghorbanian , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/2] staging: vt6656: Use define instead of magic number for tx_rate Date: Tue, 7 Apr 2020 18:39:14 +0200 Message-Id: <20200407163915.7491-2-oscar.carter@gmx.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200407163915.7491-1-oscar.carter@gmx.com> References: <20200407163915.7491-1-oscar.carter@gmx.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:80gdE0QlBjoYBKLhB15CgxM2/0qdTaSX6YXBn+M3I/XTjQLkEk3 3f0twBV+6Yee+7jaZPU22/kN3PSGSMQ66NAgUhe8DuUmTceeVyFXYiVZCe2uCQUns1TsohY 1nwjSyS56NHIAhpL9fkGluik6/oYFMfpooPwtkyL3pwF2LgkZGSld0+Qy3kEHharogd5kAb 5r7MVEicf+xLoMhJ/Q+Gw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:irZJPE8IK2k=:HeMx1OxnRCK+wsO10X51Vk i5SrpEPdI2/YYhcsvTSeD0pAqRfzqCuvxPHec1oNK5J989yA9Y4T0QNyQczh0gbMTU25Fihbl 68pae8CJa/eY0JBekvUcK89U3sHM3xjeIRwWdcxyReKnqiYutEVLbZtDxc/6p1adzD/xn52W4 XAM9o0muwLDcXTBQhUvlMwSiW8djbjrlTFMaNYvpv8laq1OIYQgtKDNgsTGYc+OHM7x2PDebQ Rb0kv7IZeE0AW39fJ5yf0vWdxv6Li4M3fCxKJ3E1QnaOVhBq/3urmdWo2a7aa680AlcOhfhDs dGRhfOYpK66KRTW8DArOdPQLhLD/fqsYR2d+c1lJMxQ2JTy4lM+cCrDXWDCymNLaSatsPsIWn NSC5wTdV1q4iwhP3x5LZXptBnBtDKe2wEVQk0b+p4Y2TEtvqKab6Qg0+HI5kW/Rfb3XekvOEZ w52dHxPKZMUSgOHE0cy47WcVG90WcG7zFhJDTXxNNPOqksZmWqzgA1nSe/M0oOm/QV3lIMr7T g7qXXu/F9jSapRQo4TttvfaLvYU1OAyqceIzemJpKQn5+boCSRwQMledNsnoovZ20qvxTgonn hxHAzzT63wIUwQGRDvNpCgIGs9PQVThKryM64lCdQcCZ13gy2y/QRdEWoKS7oX1swhftn2Mpc ipU7XTMU3X0xMTMeI4Mg6jrXo/wcTX7ScjnKeTut4h69sAyRHnPpS/cao/avWlbPgoEhr76jd K85uPgqIQ2fKTPg/rRH6kincw3spMCJH6vKayFB952fYyT8gKqttWSacP+zsLo38cHF5snrcD gJ5V0vjaTB4IoWr+ARtZOl/XtkAYZdENw3xX4Hsa04hJCDJFNnqUfWoI1KRlw/f9f4SVN0UOj GpFtPPBbznyVmx4p17t9v5Uo+IhcqhxdMb6e/zniWABhBC2ypEnnxTFrj1LQ5RNoQWifW567f RhnadIX93eML1XTG4BNwpPYd7/Rj6bvEheCVVnr7heLCgpFI6OHlEmpGcPgoLcw6bZS3sl/GX 13+w3gqk+GtLjW7rQeM7M1GsGtjL+8Covvge1NhnK32Cpv0qEpZKC+hFhp6/CXX3px0k6D0pd AFbJ4+N9dAmNSr9W40nWHZqqFH6VIfX0QTMZZs8aW22psH3TIeOjx7QPpOuv7ZJidcA/TZATE uBB2kyJVfMeTzjUwAqE22ZfK6IOEsGPAfMMBWi5QrWdkT3v9EuSaIm7B0k93G55dkNV05cMuO fnEjETBqQpq1DZ2CA Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the define RATE_11M present in the file "device.h" instead of the magic number 3. So the code is more clear. Reviewed-by: Dan Carpenter Signed-off-by: Oscar Carter =2D-- drivers/staging/vt6656/baseband.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/baseband.c b/drivers/staging/vt6656/ba= seband.c index a19a563d8bcc..092e56668a09 100644 =2D-- a/drivers/staging/vt6656/baseband.c +++ b/drivers/staging/vt6656/baseband.c @@ -24,6 +24,7 @@ #include #include +#include "device.h" #include "mac.h" #include "baseband.h" #include "rf.h" @@ -141,7 +142,7 @@ unsigned int vnt_get_frame_time(u8 preamble_type, u8 p= kt_type, rate =3D (unsigned int)vnt_frame_time[tx_rate]; - if (tx_rate <=3D 3) { + if (tx_rate <=3D RATE_11M) { if (preamble_type =3D=3D 1) preamble =3D 96; else =2D- 2.20.1