Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4742707ybb; Tue, 7 Apr 2020 13:35:45 -0700 (PDT) X-Google-Smtp-Source: APiQypKbLs2nzsdYQtHDKG6csfBSdEG8U6gLRiqMInjK0RTKfRiPTH8jnX4+1cLsA64JS2Pn805u X-Received: by 2002:aca:ec16:: with SMTP id k22mr526016oih.177.1586291745080; Tue, 07 Apr 2020 13:35:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586291745; cv=none; d=google.com; s=arc-20160816; b=HifFVMZksejBrlm6Z1ZfSA/nFeCDVJUfOZvCR3IPiNSF87fJ1rvl12VSdf9kTC1rbs 5WRgWjilXwJ9GPZQyGHzVsXA1u3QfXkHHNxsxIkzL8bDYwtaUpuAAEkQGAQ8tToJ8bPz 2u5CrxDTEC/+ingLMJOo/K18A+rPIb8qDk2WtFRP5NgYcrVpHJWG8OX65yNrkd3B9sn3 pXtdNWVQYAMZLx8utPzvpvuXV24ffYdiy3Xyt/doB8pC3m9WbN2770c6k8dtNTFEaFMu Eh1JA4seN1FiJzPa2yLosg3w9CUpDF5sDcZO14NtoY/bK0IRQTyDFBsTflSqOno4+I13 glJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:date:to:cc:from :subject:references:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=YRABWMvwvHV0PmDLsBbttXpDhy97LPhtP+IKmrC+GN4=; b=gRcCCkeRpxFIoFOz7fS10JJIrxjHCw7rbkvy+I4EG3nTUCeEW6T3jexczIy3oqLvYN 6URF2nyT2rvjSvV3i7hfhLR4JqgUlAgQBRAzewThn7rM6gzEVZas4Vs2J8yRq5nMQAUN ewe5oT6AgR+3BB+gTfqYLDp/SDPya2M/jfXu5a0uNGEsbEBMBr7h+mOIBFUtOgPMDSPT mtonWndLzjSTomP7HcRQ3mn0N5CuFzCtqCNcL3es/ryFHPtPzBwL/og4BFXSGklRuB4t Sgw3IsTSnfovAfP3PoDpwz4g1OK9F3JeP0L97H/mkhc+fIOqrWs0hU4MNzNdCv+t0Ovq b+iA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=myOh01Dm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l75si1011360oig.59.2020.04.07.13.35.30; Tue, 07 Apr 2020 13:35:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=myOh01Dm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726443AbgDGUeu (ORCPT + 99 others); Tue, 7 Apr 2020 16:34:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:41408 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726277AbgDGUeu (ORCPT ); Tue, 7 Apr 2020 16:34:50 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AC62C2074B; Tue, 7 Apr 2020 20:34:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586291689; bh=YRABWMvwvHV0PmDLsBbttXpDhy97LPhtP+IKmrC+GN4=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=myOh01Dmx+KkdWrwz40Cn7g/n00RxRMho1HYuUNqGKXOcalbV/rv3vk/Ni5UOFIMf wjSfQFrDMjiu+Kpe0IwkQFz09Dx/Ah2ANqDryLaB5RDYetyY4DoKURVSBQ5BgWy9ux oXBEvtnVgLj4JdHZEFyUDi4buGHDcpmErypEZF5Q= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20200331104532.12698-1-chunyan.zhang@unisoc.com> <158605608663.158626.7732167785990086489@swboyd.mtv.corp.google.com> Subject: Re: [PATCH] clk: sprd: don't gate uart console clock From: Stephen Boyd Cc: Michael Turquette , linux-clk , Linux Kernel Mailing List , Orson Zhai , Baolin Wang , Chunyan Zhang To: Chunyan Zhang Date: Tue, 07 Apr 2020 13:34:48 -0700 Message-ID: <158629168890.88454.8918367547173437575@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Chunyan Zhang (2020-04-06 19:02:38) > On Sun, 5 Apr 2020 at 11:08, Stephen Boyd wrote: > > > > Quoting Chunyan Zhang (2020-03-31 03:45:32) > > > Don't gate uart1_eb which provides console clock, gating that clock w= ould > > > make serial stop working if serial driver didn't enable that explicit= ly. > > > > > > Signed-off-by: Chunyan Zhang > > > --- > > > > Do you have a Fixes: tag? >=20 > I didn't leave a Fixed tag since that commit [1] will be merged into v5.7= -rc1 >=20 > [1] https://www.spinics.net/lists/linux-clk/msg46430.html Please still provide a Fixes tag. It helps track what commit is fixed regardless.