Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Namjae Jeon" <namjae.jeon@samsung.com>
To:     "'Tetsuhiro Kohada'" <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
Cc:     <Mori.Takahiro@ab.MitsubishiElectric.co.jp>,
        <motai.hirotaka@aj.mitsubishielectric.co.jp>,
        "'Sungjong Seo'" <sj1557.seo@samsung.com>,
        <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
In-Reply-To: <20200407083410.79154-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
Subject: RE: [PATCH] exfat: remove 'bps' mount-option
Date:   Wed, 8 Apr 2020 09:03:27 +0900
Message-ID: <001301d60d39$212ccf10$63866d30$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQICYKfYu26zgRX3njdSPq1gDqANSAEqKKnpqAxejhA=
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20200407083445epcas1p243e93ccad42ed28249356d01bbe8bc7d@epcas1p2.samsung.com>
        <20200407083410.79154-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> remount fails because exfat_show_options() returns unsupported option
> 'bps'.
> > # mount -o ro,remount
> > exfat: Unknown parameter 'bps'
> 
> To fix the problem, just remove 'bps' option from exfat_show_options().
> 
> Signed-off-by: Tetsuhiro Kohada
> <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
I will apply your patches after setting up exfat git tree.

Thanks for your work!
> ---
>  fs/exfat/super.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/exfat/super.c b/fs/exfat/super.c index
> 2dd62543a4..1b7d2eb034 100644
> --- a/fs/exfat/super.c
> +++ b/fs/exfat/super.c
> @@ -151,7 +151,6 @@ static int exfat_show_options(struct seq_file *m,
> struct dentry *root)
>  		seq_puts(m, ",iocharset=utf8");
>  	else if (sbi->nls_io)
>  		seq_printf(m, ",iocharset=%s", sbi->nls_io->charset);
> -	seq_printf(m, ",bps=%ld", sb->s_blocksize);
>  	if (opts->errors == EXFAT_ERRORS_CONT)
>  		seq_puts(m, ",errors=continue");
>  	else if (opts->errors == EXFAT_ERRORS_PANIC)
> --
> 2.25.0