Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp129680ybb; Tue, 7 Apr 2020 18:39:31 -0700 (PDT) X-Google-Smtp-Source: APiQypL85Bc8q2ytADSbVh9I0k0klSGIB3eyOM0Mn6K9+nPpb4/LNvN9HoSPWq1WcGiB5M+6O+HF X-Received: by 2002:aca:4082:: with SMTP id n124mr754305oia.112.1586309971247; Tue, 07 Apr 2020 18:39:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586309971; cv=none; d=google.com; s=arc-20160816; b=LkywbMrhGpHdLN7OXRcuJKPYqdyc/rq/niZ6cWCDsKkfROkN6t9jUn6kLCqmEf1kOI gAo5c+db9G8oW5WPtURtgnot2ThSqLDW2j4nKGVvUXE6UwFhuD61EqsjIpoLRSEzO41U 6EWQFbwEpIi6LwrLlvqXktLhadvc6dIw4pVlHbLqmqDsdqKxGTBSeV4EFi9Cb/tZnqwj oEoBa+uRywsOmoRzOmPYiGFW7VyI/O3tuam8FegFRMmlXmspTEw2HdYocyiy/RPGMitx EllAqBrhQxq9mTKUB7wOwKJ3b7sNjT9PyqqaAmkBWlwr7TGqgakA6ovxCIvBnYNeLKi7 OoZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=Aq2EuwB4lclwg5qoKcqG0vPVV5jq9jQYhLlQDpi6jNc=; b=WzuBPKIRlIjr+nSJWs0YQ7acETh0KrXRJFQHfpRp522qgp+Nv4EKnMSHf0j+BTqIxK ReL8buU6Q5WQLcd726olhyrwDNIvKZN8QOQYOO6NcUkQilQZDALLL0ndGCnzTbm5645a lcU1OJra/2mD7yGM4cVSUFrxprfzDMXIltIzbsxhIfbusOaT2Cihr8vcJaG6CwvTCU3n n/FBUv1+pvJruC8HEVOIPbGKEbL7B9t78yuZU1CbJUj+0KcZLHSKtGpg40Eht0v9rswC b49jAYkHnUINs68hSB9DGsATB2TkHVFzc2eUtRt/Ce5ioxvFsZ3dZmlm5mE3CHc6KLsC 8EHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l9si1996086otf.51.2020.04.07.18.39.16; Tue, 07 Apr 2020 18:39:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726550AbgDHBiL (ORCPT + 99 others); Tue, 7 Apr 2020 21:38:11 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:44376 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726407AbgDHBiL (ORCPT ); Tue, 7 Apr 2020 21:38:11 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D9E4B1210A3E3; Tue, 7 Apr 2020 18:38:09 -0700 (PDT) Date: Tue, 07 Apr 2020 18:38:08 -0700 (PDT) Message-Id: <20200407.183808.1820111338460470376.davem@davemloft.net> To: wenhu.wang@vivo.com Cc: kuba@kernel.org, bjorn.andersson@linaro.org, allison@lohutok.net, hofrat@osadl.org, mkl@pengutronix.de, tglx@linutronix.de, arnd@arndb.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.org Subject: Re: [PATCH] net: qrtr: send msgs from local of same id as broadcast From: David Miller In-Reply-To: <20200407132930.109738-1-wenhu.wang@vivo.com> References: <20200407132930.109738-1-wenhu.wang@vivo.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 07 Apr 2020 18:38:10 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: WANG Wenhu Date: Tue, 7 Apr 2020 06:29:28 -0700 > - enqueue_fn = qrtr_bcast_enqueue; > - if (addr->sq_port != QRTR_PORT_CTRL) { > + if (addr->sq_port != QRTR_PORT_CTRL && > + qrtr_local_nid != QRTR_NODE_BCAST) { Please line up the second line of this if() statement with the column after the openning parenthesis of the first line.