Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC] net/mlx5: Fix failing fw tracer allocation on s390
To:     Markus Elfring <Markus.Elfring@web.de>, netdev@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eran Ben Elisha <eranbe@mellanox.com>,
        Leon Romanovsky <leon@kernel.org>,
        Moshe Shemesh <moshe@mellanox.com>,
        Saeed Mahameed <saeedm@mellanox.com>
References: <77241c76-4836-3080-7fa6-e65fc3af5106@web.de>
From:   Niklas Schnelle <schnelle@linux.ibm.com>
Date:   Wed, 8 Apr 2020 10:06:44 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <77241c76-4836-3080-7fa6-e65fc3af5106@web.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Message-Id: <7eaec712-6427-7adf-98cd-2c4347dd9e85@linux.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 4/7/20 5:12 PM, Markus Elfring wrote:
>> On s390 FORCE_MAX_ZONEORDER is 9 instead of 11, thus a larger kzalloc()
>> allocation as done for the firmware tracer will always fail.
> 
> How do you think about to add the tag “Fixes” to the final change description?
> 
> Regards,
> Markus
> 
You're right that makes a lot of sense, thanks! I guess this should reference
the commit that introduced the debug trace, right?

Best regards,
Niklas