Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp395862ybb; Wed, 8 Apr 2020 01:57:17 -0700 (PDT) X-Google-Smtp-Source: APiQypIC3905bzvLDrSg078Uch+kNj410nWi1sp+59ENGquZQurHCLABj4+uZwYPHMMdxmIk6MDq X-Received: by 2002:a05:6830:1104:: with SMTP id w4mr5106795otq.54.1586336237820; Wed, 08 Apr 2020 01:57:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586336237; cv=none; d=google.com; s=arc-20160816; b=llEuKTXApgXTQe2GqMb/Gvaj83dpZDwzg3r0l81aeHeczGhuBUG5YwYgYvrC7IcQR9 80IKecUj7wPPChW9zPBNTwCYLXuQIY5u+dVaZ59cQS4e+7vfnscQEQ4WcxUgDTeFaTNF 54VHMdk1LU5bIfOqm8U2XRw4ILtFd7s1V2oux40KAZzqQABVkC+GlqXaP1UOXxtJAGNM B3XzSBwgp4WxGkRXyGPoHJL2Byl8MIFlWpswfP6H6Q9J9BKr9npUaJsuqfJXwdN2DSdu DHUX4U+DcdI1/rca9s+VZm916vBcNd/mIxqJRGKDJeGIewSYqtNnXL9+VmVMJwnZdXdn JCzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=LGMlwxA6iQKlbkoboMiMffftFbfeoS94qV39YmWsn/s=; b=YoeH/+XWR1jZQgQap0oEofSvRyXiCGRnkku4HBj+70bZWP0p/Di7g3RJDgRGrv2fwV htOVk0k8qNAnDbsVZXzZ8A2hxhznsz35Fi8JFONbYMFfslLSaoZbrCJR0XGztzw86wuH 0D/u64zvzL33yPS4kiMsN/qJDzsPUIkh+YJGV+LfNY59R+4nWkpdEm83WDqxh/8efMip SRo5+1gI1iz2Q0zn0xqEubSqAKwM9sWejuO2R7xRCiqeSq5XYF6DyTEaBtIF65mtKqAK q8ehWp4U1p6YdqnRRBcu2DmCZmOcu0X3+uKvtptyJIQy75IjQTmFBM3gthzJN8ZnF5b1 29Ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=A1T8p1qr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 67si2253257otj.108.2020.04.08.01.57.03; Wed, 08 Apr 2020 01:57:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=A1T8p1qr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727716AbgDHIw3 (ORCPT + 99 others); Wed, 8 Apr 2020 04:52:29 -0400 Received: from merlin.infradead.org ([205.233.59.134]:40432 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726795AbgDHIw2 (ORCPT ); Wed, 8 Apr 2020 04:52:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LGMlwxA6iQKlbkoboMiMffftFbfeoS94qV39YmWsn/s=; b=A1T8p1qrP/TaONEfVnHluuKPl6 Z3hadrSaWt4qacRmm4slU8C7HNzwELWEnY3G/eoSYaEWV4+mAH0Hm37saLoY4cThh7O3pY+uKpAH+ QIf2PLD6extSoXdd9/EIb/thI85jjdsiWH/GDOfdPWh8nVmKaeMp1VtOb0Y/DYbA7ekKtJe39XYtH acw7CTuWPMhtu1svywaojutx/huJ3T3sHDNMKz5phmULRjLmaJGcG++drinY7dFO2RgwnwZx/xeck H6l0P+6r7g45ImA2owX87KEl+CrNuO2u3JiulaIt0GoGl243xv9roJTx/Tj7lkC7Cxlp4lIDGAVNK CJERZ3xA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jM6Qu-0006Ln-9K; Wed, 08 Apr 2020 08:51:40 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 87400305FB6; Wed, 8 Apr 2020 10:51:38 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 735992BB00B60; Wed, 8 Apr 2020 10:51:38 +0200 (CEST) Date: Wed, 8 Apr 2020 10:51:38 +0200 From: Peter Zijlstra To: Jan Kiszka Cc: Steven Rostedt , tglx@linutronix.de, linux-kernel@vger.kernel.org, hch@infradead.org, sean.j.christopherson@intel.com, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org, kenny@panix.com, jeyu@kernel.org, rasmus.villemoes@prevas.dk, pbonzini@redhat.com, fenghua.yu@intel.com, xiaoyao.li@intel.com, nadav.amit@gmail.com, thellstrom@vmware.com, tony.luck@intel.com, gregkh@linuxfoundation.org, jannh@google.com, keescook@chromium.org, David.Laight@aculab.com, dcovelli@vmware.com, mhiramat@kernel.org, Wolfgang Mauerer Subject: Re: [PATCH 4/4] x86,module: Detect CRn and DRn manipulation Message-ID: <20200408085138.GQ20713@hirez.programming.kicks-ass.net> References: <20200407110236.930134290@infradead.org> <20200407111007.429362016@infradead.org> <20200407174824.5e97a597@gandalf.local.home> <137fe245-69f3-080e-5f2b-207cd218f199@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <137fe245-69f3-080e-5f2b-207cd218f199@siemens.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 08, 2020 at 07:58:53AM +0200, Jan Kiszka wrote: > On 07.04.20 23:48, Steven Rostedt wrote: > > Hmm, wont this break jailhouse? Breaking it isn't a problem, it's out of tree and it should be fixable. > Yes, possibly. We load the hypervisor binary via request_firmware into > executable memory and then jump into it. So most of the "suspicious" code is W.T.H. does the firmware loader have the ability to give executable memory? We need to kill that too. /me goes find.