Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 8 Apr 2020 04:21:52 -0700
From:   Matthew Wilcox <willy@infradead.org>
To:     Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.mitsubishielectric.co.jp>
Cc:     Mori.Takahiro@ab.mitsubishielectric.co.jp,
        motai.hirotaka@aj.mitsubishielectric.co.jp,
        Namjae Jeon <namjae.jeon@samsung.com>,
        Sungjong Seo <sj1557.seo@samsung.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] exfat: replace 'time_ms' with 'time_10ms'
Message-ID: <20200408112152.GP21484@bombadil.infradead.org>
References: <20200408074610.35591-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200408074610.35591-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Please leave at least 24 hours between sending new versions so that
you can collect all feedback relating to your change, and we don't see
discussion fragment between different threads.

> @@ -84,10 +84,10 @@ void exfat_get_entry_time(struct exfat_sb_info *sbi, struct timespec64 *ts,
>  			      t >> 11, (t >> 5) & 0x003F, (t & 0x001F) << 1);
>  
>  
> -	/* time_ms field represent 0 ~ 199(1990 ms) */
> -	if (time_ms) {
> -		ts->tv_sec += time_ms / 100;
> -		ts->tv_nsec = (time_ms % 100) * 10 * NSEC_PER_MSEC;
> +	/* time_10ms field represent 0 ~ 199cs(1990 ms) */
> +	if (time_10ms) {
> +		ts->tv_sec += (time_10ms * 10) / 1000;
> +		ts->tv_nsec = (time_10ms * 10) % 1000 * NSEC_PER_MSEC;

I find this more confusing than the original.

		ts->tv_sec += time_10ms / 100;
		ts->tv_nsec = (time_10ms % 100) * 10 * NSEC_PER_MSEC;

is easier to understand for me, not least because I don't need to worry
about the operator precedence between % and *.