Subject: Re: [PATCH 2/7] isdn4linux: Siemens Gigaset drivers - event layer
From: Arjan van de Ven <arjan@infradead.org>
To: Hansjoerg Lipp <hjlipp@web.de>
Cc: Karsten Keil <kkeil@suse.de>, i4ldeveloper@listserv.isdn4linux.de,
       linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
       Greg Kroah-Hartman <gregkh@suse.de>, Tilman Schmidt <tilman@imap.cc>
In-Reply-To: <gigaset307x.2006.02.27.001.2@hjlipp.my-fqdn.de>
References: <gigaset307x.2006.02.27.001.0@hjlipp.my-fqdn.de>
	 <gigaset307x.2006.02.27.001.1@hjlipp.my-fqdn.de>
	 <gigaset307x.2006.02.27.001.2@hjlipp.my-fqdn.de>
Content-Type: text/plain
Date: Mon, 27 Feb 2006 09:01:48 +0100
Message-Id: <1141027308.2992.47.camel@laptopd505.fenrus.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 545
Lines: 17

On Mon, 2006-02-27 at 07:23 +0100, Hansjoerg Lipp wrote:
> +static inline void new_index(atomic_t *index, int max)
> +{
> +       if (atomic_read(index) == max)  //FIXME race?
> +               atomic_set(index, 0);
> +       else
> +               atomic_inc(index);
> +}

yes.. that's a race.....


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/