Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To:     John Stultz <john.stultz@linaro.org>,
        lkml <linux-kernel@vger.kernel.org>
CC:     "David S. Miller" <davem@davemloft.net>,
        Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        Rob Herring <robh@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        netdev <netdev@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: RE: [RFC][PATCH v2 2/2] driver core: Ensure wait_for_device_probe()
 waits until the deferred_probe_timeout fires
Thread-Topic: [RFC][PATCH v2 2/2] driver core: Ensure wait_for_device_probe()
 waits until the deferred_probe_timeout fires
Thread-Index: AQHWDXcYaRasF4w8J0WGvexXGfCK66hvBRAg
Date:   Wed, 8 Apr 2020 10:29:20 +0000
Message-ID: <TYAPR01MB45443540F0A3729AD2B98A96D8C00@TYAPR01MB4544.jpnprd01.prod.outlook.com>
References: <20200408072650.1731-1-john.stultz@linaro.org>
 <20200408072650.1731-2-john.stultz@linaro.org>
In-Reply-To: <20200408072650.1731-2-john.stultz@linaro.org>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
received-spf: None (protection.outlook.com: renesas.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 09470796-8ad4-4b05-6111-08d7dba7b30c
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2020 10:29:20.4989
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lCALL4+8Ftz43rBN1wRRTbslE5lrMS9pfOIcchNdYAAAIKlAIuVBEr02KaR4bO9uJj/irJQ+y22bhPzLEystF56xlPLmZAgQQtKRK8LNJY4OYWweWWDCNAMdpzVWkaq7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB2735
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi John,

> From: John Stultz, Sent: Wednesday, April 8, 2020 4:27 PM
>=20
> In commit c8c43cee29f6 ("driver core: Fix
> driver_deferred_probe_check_state() logic"), we set the default
> driver_deferred_probe_timeout value to 30 seconds to allow for
> drivers that are missing dependencies to have some time so that
> the dependency may be loaded from userland after initcalls_done
> is set.
>=20
> However, Yoshihiro Shimoda reported that on his device that
> expects to have unmet dependencies (due to "optional links" in
> its devicetree), was failing to mount the NFS root.
>=20
> In digging further, it seemed the problem was that while the
> device properly probes after waiting 30 seconds for any missing
> modules to load, the ip_auto_config() had already failed,
> resulting in NFS to fail. This was due to ip_auto_config()
> calling wait_for_device_probe() which doesn't wait for the
> driver_deferred_probe_timeout to fire.
>=20
> This patch tries to fix the issue by creating a waitqueue
> for the driver_deferred_probe_timeout, and calling wait_event()
> to make sure driver_deferred_probe_timeout is zero in
> wait_for_device_probe() to make sure all the probing is
> finished.
>=20
> The downside to this solution is that kernel functionality that
> uses wait_for_device_probe(), will block until the
> driver_deferred_probe_timeout fires, regardless of if there is
> any missing dependencies.
>=20
> However, the previous patch reverts the default timeout value to
> zero, so this side-effect will only affect users who specify a
> driver_deferred_probe_timeout=3D value as a boot argument, where
> the additional delay would be beneficial to allow modules to
> load later during boot.
>=20
> Thanks to Geert for chasing down that ip_auto_config was why NFS
> was failing in this case!
>=20
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
> Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: netdev <netdev@vger.kernel.org>
> Cc: linux-pm@vger.kernel.org
> Reported-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Fixes: c8c43cee29f6 ("driver core: Fix driver_deferred_probe_check_state(=
) logic")
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
> * v2: Split patch, and apply it as a follow-on to setting
>       the driver_deferred_probe_timeout defalt back to zero
> ---

Thank you for the patch! This patch doesn't cause any side
effect on my environment (the value of driver_deferred_probe_timeout is 0).
So,

Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda