Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp624436ybb; Wed, 8 Apr 2020 06:47:56 -0700 (PDT) X-Google-Smtp-Source: APiQypKgjcaJgHvCL7QIAAMzEBO/4cJORdRx/ex1c9zl6lSEuCwaWznaawD/cBEATXiiSYpxfyWX X-Received: by 2002:a05:6808:8ce:: with SMTP id k14mr2612073oij.60.1586353676092; Wed, 08 Apr 2020 06:47:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586353676; cv=none; d=google.com; s=arc-20160816; b=0LWAiEDcgMPKD6J5sLiWDCwJrAlSigYTzAnpRTrMgEQUCUouCEVhUQOfdcZkVqfCbk 2Zr0DwztPFXwqEQwH+8UgX1+J/SspXNcQxGiYSvepXtKYOjtr2EsiUndhLTqB/KeN5fT urmuGaEjbvuUS6THBfGiiu8+7azXKNqn0Y/tvqMHw7KUJ98Lh9RhSgmaSxKhiFSmhFI8 YVOAbZkwnxniXFEs0vuE7WWO6LzU74OV8XmDq5w4atCAhWYiHKhesNibWUd1TWRZa7xV aVqcrR/3YBdOdEkk6n86CBFPIq7Ucfr2yznoZBVUwcCHvpHDzX+LJ04VPFUWiqxrdx9g zMIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=3ZqnNnyTvHfqcEkmuTyQ2LPQ2OpYuhXibwpvxMqZKrM=; b=L+rm9uXmU7xUfIR425TWOkOy0dg8mJLb+DqfhZo5c61l0dMrgvCqxp9ur705EL4qg5 LZzU7u8v9gNk+23EuARIATbbRipYCPp7nKaCK9zVrt4MO7yh8lbvofNu3Ur/zl9pJgqr Jlt5uFeLPK4MEY7QOpDh7tvH1BrsJzVooXHTgwNRbrNnPNbhc5wN7lqUn3FwwEYS/l0V EHdPF/hXXICfNmG/D/BoHAKacV6di/bxSre56doPS+FIICYESMzgWSrdfZ2SOW+QvCG0 HUYqZGzDU4ijtAvsRWIbe4G2HdgJUhwY1cYT5r1IOd/bL2kEW62MQoAcU5Hrd9hxgqB4 xJHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=Wq6VQLh7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y35si2381624otb.315.2020.04.08.06.47.41; Wed, 08 Apr 2020 06:47:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=Wq6VQLh7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728742AbgDHMVh (ORCPT + 99 others); Wed, 8 Apr 2020 08:21:37 -0400 Received: from merlin.infradead.org ([205.233.59.134]:57288 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726605AbgDHMVh (ORCPT ); Wed, 8 Apr 2020 08:21:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3ZqnNnyTvHfqcEkmuTyQ2LPQ2OpYuhXibwpvxMqZKrM=; b=Wq6VQLh7N6K0YWKu3Ue3rhR1W6 uPBkkMsNf6/oDdxLwjvSEebhtXDxpta8ctMX3AXxxQtPmAR2J+2NvjDAQ2GuZQbEgQcRFIs0Uh8a4 q/KDbO0lwFUvtXqown2kw13Y2h8hXVn8KbPRn0q+BAyo1R4JeWx6mLApKc3oAhNA7djcKdAw1oQbM KRmYIUtFQOJZvRFNoOcseeSgBXpm6Sgnq9wqzvLPflPkgGLBpryMqX12jZ7xIgN+vL/xiKvc+GPAO H86wFLe8WEU+0qO5K7uXu5rgIXC3C0pN4XcAwuVMP5rzFHvMEfrrCJTR2fn2NFfwMo4f+UhEJBb/M 0BvJqDAg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jM9hd-0001dI-4e; Wed, 08 Apr 2020 12:21:09 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id CE886307972; Wed, 8 Apr 2020 14:21:04 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id B4EEE2B2354E8; Wed, 8 Apr 2020 14:21:04 +0200 (CEST) Date: Wed, 8 Apr 2020 14:21:04 +0200 From: Peter Zijlstra To: Christoph Hellwig Cc: Andrew Morton , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , x86@kernel.org, David Airlie , Daniel Vetter , Laura Abbott , Sumit Semwal , Sakari Ailus , Minchan Kim , Nitin Gupta , Robin Murphy , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 17/28] mm: remove the prot argument from vm_map_ram Message-ID: <20200408122104.GZ20713@hirez.programming.kicks-ass.net> References: <20200408115926.1467567-1-hch@lst.de> <20200408115926.1467567-18-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200408115926.1467567-18-hch@lst.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 08, 2020 at 01:59:15PM +0200, Christoph Hellwig wrote: > This is always GFP_KERNEL - for long term mappings with other properties > vmap should be used. PAGE_KERNEL != GFP_KERNEL :-) > - return vm_map_ram(mock->pages, mock->npages, 0, PAGE_KERNEL); > + return vm_map_ram(mock->pages, mock->npages, 0);