Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp708946ybb; Wed, 8 Apr 2020 08:26:34 -0700 (PDT) X-Google-Smtp-Source: APiQypKnGSLDb5rJta0HRw6VAAmEG8124wJmST1KdQ9wcECq8E1a3XGTt1MU/qQxpUIMQrgcl24k X-Received: by 2002:a9d:7c94:: with SMTP id q20mr5372064otn.150.1586359594342; Wed, 08 Apr 2020 08:26:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586359594; cv=none; d=google.com; s=arc-20160816; b=C2k5bO+1p9EvBwPpWqNOEF+o0ikq8ppkVLLkwJhuuizZU2weyggTcEzj0LwO3JzBXx yUcOeH5F6e2dAG7klwQfCp6bpbvun/LJmGCLS+uvuvaSpo3C64UYu8ZQo9StjpPvs0UA xa3EITge3wc8DL9NdLvzRfg74g8C3UAAlQY93EE/b34zXurgjYGvu75y6dEkskfssKjJ /IgJ5oruFY2UdLnksjeGVRuWyIz9ZzqhmSZsxG4mVGTaWI1FXmTIReZcYRVzzumu9E17 9segs0VHrtm2OkWzYoVuM87OtXr0MEVrkEVMHbGkw3P2mH7yJBTEGlW659GeEPyIU4Qu O1mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=7j15irdsaxGX8cfTWAC6matDqLKA3gIZxxOmemamMLM=; b=0ABvYIYzoStW1K7XICLUM5+ORE0MF1s4PJBnZZDqVvD+iimC03ScpmkndxKME/koTg ZniI70r5wC18UJeoJNpKem+z+09n1xF5PT+L0GHbAtg6F/K69U866+mrS1++LVCrcAwX /ze8YMNQuzqwwRTC4sTC04iWyiRMRQYTA22qzFctMcfHstnjL0r/MfFRXoECT40KoxDf o4zZTceYQwH8WIQBlTsFtcLV5Ar3Dlv+o9j4NdiAvPUKnYXlyhfa22SqIJx1ftRcM4jV v76q1DTLmFRNHHRkS+TDt7vC2bYYesYmqOVDFdZief+XBUxtFwfugCWpWgfCqXfGcXUD MMQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=RPEB5PM7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 97si2519284oth.209.2020.04.08.08.26.15; Wed, 08 Apr 2020 08:26:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=RPEB5PM7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729264AbgDHPBD (ORCPT + 99 others); Wed, 8 Apr 2020 11:01:03 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:50910 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727929AbgDHPBD (ORCPT ); Wed, 8 Apr 2020 11:01:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=7j15irdsaxGX8cfTWAC6matDqLKA3gIZxxOmemamMLM=; b=RPEB5PM73ynSvK416UNxfE6GIR mZshayq2k05WAcYJu/+/rVKoK6NKG7B3MH4ANvlIlgjmk7SZQ9SVZvCi1iFzh152x1dc5HFwC6wiB qZ7+wtgUYAJ/AL1+Nrnu40kKBJNxHFgPazhMH2Ric3UWgKjdkfBZZ4L5DzjO4UWC8nOiEfakNU3sL xeYGj2y01wlVJ6IMOAIJN1BDOjqY06mtmnlOMMnimuv0Lk5fEUfE8xZSq6u7bkZB9iCd/RQJzE/kr AiM4v2OB70pEwCX5052hN8D8H6d2m6wVwy7YCb7MRCFvqlow1x10n6P0OTVWoUlmG05Xu6u09f4Jd +6y90bjw==; Received: from [2601:1c0:6280:3f0::19c2] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMCCM-0006Vd-CA; Wed, 08 Apr 2020 15:01:02 +0000 Subject: Re: [PATCH 10/28] mm: only allow page table mappings for built-in zsmalloc To: Christoph Hellwig , Andrew Morton , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , x86@kernel.org, David Airlie , Daniel Vetter , Laura Abbott , Sumit Semwal , Sakari Ailus , Minchan Kim , Nitin Gupta Cc: Robin Murphy , Christophe Leroy , Peter Zijlstra , linuxppc-dev@lists.ozlabs.org, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200408115926.1467567-1-hch@lst.de> <20200408115926.1467567-11-hch@lst.de> From: Randy Dunlap Message-ID: Date: Wed, 8 Apr 2020 08:01:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200408115926.1467567-11-hch@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 4/8/20 4:59 AM, Christoph Hellwig wrote: > diff --git a/mm/Kconfig b/mm/Kconfig > index 36949a9425b8..614cc786b519 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -702,7 +702,7 @@ config ZSMALLOC > > config ZSMALLOC_PGTABLE_MAPPING > bool "Use page table mapping to access object in zsmalloc" > - depends on ZSMALLOC > + depends on ZSMALLOC=y It's a bool so this shouldn't matter... not needed. > help > By default, zsmalloc uses a copy-based object mapping method to > access allocations that span two pages. However, if a particular -- ~Randy