Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp714630ybb; Wed, 8 Apr 2020 08:32:38 -0700 (PDT) X-Google-Smtp-Source: APiQypLLivc8+r5D9EBnpma6Tk/0Rz6MTfdYEM69XckLEbicQS3HYiXecggVAgV5uMfPQssz9B5R X-Received: by 2002:aca:f183:: with SMTP id p125mr2883430oih.74.1586359957769; Wed, 08 Apr 2020 08:32:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586359957; cv=none; d=google.com; s=arc-20160816; b=AHQZSs2XJCdTXR4Mk81aQZe5mBYS7Y7VK9eGIgYau5ElJjVElD54z1sAZYFt4amq/I K5t3Fd/yQxNT0Bc3J+pqt20y+FLvdHmwVaG2yh9Dt0s1J35AyRRdWoIRfmQtXWJlHKyD nv2Icq/7eVubhj28t9AmKjS2LzGDyjvCj4JUAv29CH/k6n6F3DawWuCulomEgQp/cvH7 CAPWOWw9rNRrUOANyO3Fc+1YPrF6qnLFy7u8ou6AftkKLtfHVhEJzFevsKOqYJ2jJ+Hb awdfK9JC2acFnx1I/lJhHTjBuxEh8UbaTbEt2XyWpGcBBO3Nl1JtOEYBhwjCfZC8+tkP /J4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=O7WfNhI8f1lb6PW5kXHujbQHVLkGUotMPukmCgQtvWY=; b=KNUSddD6k+Glp3AIEKJSXHrH1rD3iNQpcM1unjHB5rZSeK1jc1DwjJxu61zTUbeiAZ o+EYJqOQmVemtKVxVOPM3bz7eORMyq7c8wrZABO4IMh87DUlSD3y8LEG13NdY0Cenv6x V+3Qk4Y++MSMbVCgSfbBakbvtuWqTQ52YicHbyAd2GlTJ13A8okdKFgeyvk5Hs349uCJ qi7GfcoA/DyK2p6vu8wnhgjEksPVuG4opdXNVX/V4t8ObXUD7Zl8bWo/tzXzY0AemKio aK5bhCGnhnWV5GuUeUiYozXU/TB4enYx/0uJTCUNmA2X9Rqns7EhfXrf9o08wKbnXbK6 XOCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=TkbTZ3im; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y19si1995236oie.128.2020.04.08.08.32.21; Wed, 08 Apr 2020 08:32:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=TkbTZ3im; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728670AbgDHP1W (ORCPT + 99 others); Wed, 8 Apr 2020 11:27:22 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:40858 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727254AbgDHP1V (ORCPT ); Wed, 8 Apr 2020 11:27:21 -0400 Received: by mail-pl1-f195.google.com with SMTP id h11so2615725plk.7 for ; Wed, 08 Apr 2020 08:27:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=O7WfNhI8f1lb6PW5kXHujbQHVLkGUotMPukmCgQtvWY=; b=TkbTZ3imLDeHFL3w/n+tfMNRMwjwa9tuBACNwAjcNUWZMbOLPIyh7bEByUqixcSOXC xkZpVv5LVlFb7bI8auY0NpFtQ82qWf6Y5Zm19IQMAk22dNFw09zwOGJS7J03vbbTIP3E FYsi8YR2gA18/wCGK34SabV2govLlWbwYmf1xK0NpZ4Jaai3nYmumE5PeCeWs6knoE5y n45xkh2LgxK4toUsFztNtAqfmApl04H5V8U2dKOHI/GdL1BQ9jM8dle4UgVBvHSBRn5u wdYZKqIBhSLrS5POZknxoFrhC5/oCI5l2NrCEKnbmI2JyEgLvCdqv+RNIrysz+9W15bo MNVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=O7WfNhI8f1lb6PW5kXHujbQHVLkGUotMPukmCgQtvWY=; b=ADaj+J4jP2cx+AOpKBN2NGOuyZ8Q3U5FOF+CWhOXfkb8o7edmIM2k2kS7qfQ9RENu+ F/f4UCVX8amraqJZzr1nGSpks8kDU83tL1eLZAT/1B/oLdb1Xw197kG8Y+Ep+OYkX+Hf TotN9YGdBbWvnyXuNjRAQkPBZ849HrmLJyD2w5bJGnvQym/Ibi5hfIibmk4ZCKr6Qecf 5SsjIeP3eRspbCtTJ4HDsLDFgcT+bQD6jllArFGTCq2brF+RuAKxGmRIAaf9r/6wWhzb TsL2z4WPSiYrzJ5j4L060IDnbuLcJtg7bMcyjGcXfxBaodw8GLBJgDPf6zBkeAAoeMA+ qc1Q== X-Gm-Message-State: AGi0Pubra0n6fV8y5fq+eUK47ZpCy2smLZR6ow05j6+ZuBNHrIpS1ynP uX7E6GqiPaqTSLKhGbWagznbSdngR4Thqw== X-Received: by 2002:a17:90b:3656:: with SMTP id nh22mr6013366pjb.71.1586359638209; Wed, 08 Apr 2020 08:27:18 -0700 (PDT) Received: from ?IPv6:2605:e000:100e:8c61:4466:6b33:f85b:7770? ([2605:e000:100e:8c61:4466:6b33:f85b:7770]) by smtp.gmail.com with ESMTPSA id b68sm1314338pfb.134.2020.04.08.08.27.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2020 08:27:17 -0700 (PDT) Subject: Re: [PATCH 0/4] clean early submission path To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe Message-ID: <0dffba9d-d320-0412-f17d-cc6a19f39772@kernel.dk> Date: Wed, 8 Apr 2020 08:27:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/7/20 10:58 PM, Pavel Begunkov wrote: > This is mainly in preparation for future changes, but looks nice > by itself. The last patch fixes a mild vulnerability. > > Pavel Begunkov (4): > io_uring: simplify io_get_sqring > io_uring: alloc req only after getting sqe > io_uring: remove req init from io_get_req() > io_uring: don't read user-shared sqe flags twice > > fs/io_uring.c | 113 ++++++++++++++++++++++++-------------------------- > 1 file changed, 54 insertions(+), 59 deletions(-) Looks good to me, applied. Thanks! -- Jens Axboe