Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 8 Apr 2020 17:42:25 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Hillf Danton <hdanton@sina.com>
Cc:     Christoph Hellwig <hch@lst.de>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/28] dma-mapping: use vmap insted of reimplementing it
Message-ID: <20200408154225.GA28676@lst.de>
References: <20200408115926.1467567-1-hch@lst.de> <20200408131736.9532-1-hdanton@sina.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200408131736.9532-1-hdanton@sina.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 08, 2020 at 09:17:36PM +0800, Hillf Danton wrote:
> > @@ -62,24 +42,20 @@ void *dma_common_pages_remap(struct page **pages, size_t size,
> >  void *dma_common_contiguous_remap(struct page *page, size_t size,
> >  			pgprot_t prot, const void *caller)
> >  {
> > -	int i;
> > +	int count = size >> PAGE_SHIFT;
> >  	struct page **pages;
> > -	struct vm_struct *area;
> > +	void *vaddr;
> > +	int i;
> >  
> > -	pages = kmalloc(sizeof(struct page *) << get_order(size), GFP_KERNEL);
> > +	pages = kmalloc_array(count, sizeof(struct page *), GFP_KERNEL);
> 
> Is it making sense to vmalloc pages as long as array size is bigger than
> PAGE_SIZE?

Maybe, maybe not.  But it certainly doesn't fit this series.