Date: Mon, 27 Feb 2006 03:38:43 -0500
From: Shailabh Nagar <nagar@watson.ibm.com>
Subject: Re: [Patch 4/7] Add sysctl for delay accounting
In-reply-to: <1141028784.2992.58.camel@laptopd505.fenrus.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
       lse-tech <lse-tech@lists.sourceforge.net>
Message-id: <4402BA93.5010302@watson.ibm.com>
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7BIT
References: <1141026996.5785.38.camel@elinux04.optonline.net>
 <1141028322.5785.60.camel@elinux04.optonline.net>
 <1141028784.2992.58.camel@laptopd505.fenrus.org>
User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 872
Lines: 29

Arjan van de Ven wrote:

>>+/* Allocate task_delay_info for all tasks without one */
>>+static int alloc_delays(void)
>>    
>>
>
>I'm sorry but this function seems to be highly horrible
>  
>
Could you be more specific ? Is it the way its coded or the design 
(preallocate, then assign)
itself ?

The function needs to allocate task_delay_info structs for all tasks 
that might
have been forked since the last time delay accounting was turned off.
Either we have to count how many such tasks there are, or preallocate
nr_tasks (as an upper bound) and then use as many as needed.

Thanks for reviewing so quickly.
-- Shailabh


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/