Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp856472ybb; Wed, 8 Apr 2020 11:13:21 -0700 (PDT) X-Google-Smtp-Source: APiQypJINWHHtcf25cNIlg1Qzm+8+PwhgckWC9+6myQGe1RmvYmkjtE2Hl1zraqKB/oYpefy66GA X-Received: by 2002:a05:6830:4025:: with SMTP id i5mr7031587ots.203.1586369601325; Wed, 08 Apr 2020 11:13:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586369601; cv=none; d=google.com; s=arc-20160816; b=A5n2oQ9hVfaZpiB5fkXutTaIPVBMIKmxrNQtE4PaReSA+dZyXuke49tsZRhTN02L8Z 0TsDYFMlxez6+N9bRjm1RkOjzGIeuR1GiAQZOsKsfOI4REYTRCKLOuMPz1lcv6eO+/oL wO4vSwlXSIND9C7qkLIWSjQd5XwRdlRTUuAeHiEN4f2ubasQ+mw8IToFleYZYC2UWL7d VjWCaF96TIeWAAmPmXPU1VH5I5Ya/bjJh5nVIpmQ7ElzupstKjabD/a1KsD0ZoePl1Tw m3b18f+IGI3I6yiVyNdA9gVV1P2kxCYaBOspeHSmkTrE09GDl8cbwokxlZNpYOTYYIbe 2nuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=xj7EHDeOeP45wiarOBvn8dQVStCfan+TNOD5l85qsNg=; b=Ufh+W5jqqrbsh36mfv5w5/mGYmKBncTojYHtdArvFvlwW5z4lr1B/2h2KImHykgi9S SFOoDTWc0Ts+C0BC6yQI/SJtKzWzlGIsxB5KVxS+8UGjUG8a11q/FlS86+N/AJ7XoZP8 ppq+9oH6F2mHbQ2lePGCKNCSAT8WeYUsbolBw8dYB3FPtFAQCdYbCCfJm6Szn40QC+K6 Oke7QyHdLFLl9IzhWd2EaC/F3fT8PdTOr8CSyhc5mK91hnlhV6E1ZL6Tn2EAIaOMpYnb zppqgrnLnONQNCAafsyDkwklExPj+iAX38X2qBHwIJ39Vz/C5Sj/udJ1mRgcu9dX9XZW LBTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h9si2800236otr.176.2020.04.08.11.13.08; Wed, 08 Apr 2020 11:13:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729447AbgDHPkk (ORCPT + 99 others); Wed, 8 Apr 2020 11:40:40 -0400 Received: from verein.lst.de ([213.95.11.211]:42916 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728345AbgDHPkj (ORCPT ); Wed, 8 Apr 2020 11:40:39 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 0BEE968C65; Wed, 8 Apr 2020 17:40:34 +0200 (CEST) Date: Wed, 8 Apr 2020 17:40:33 +0200 From: Christoph Hellwig To: Hillf Danton Cc: Christoph Hellwig , Andrew Morton , Christophe Leroy , Peter Zijlstra , linuxppc-dev@lists.ozlabs.org, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, syzkaller-bugs@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/28] staging: android: ion: use vmap instead of vm_map_ram Message-ID: <20200408154033.GA28499@lst.de> References: <20200408115926.1467567-1-hch@lst.de> <20200408124833.13032-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200408124833.13032-1-hdanton@sina.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 08, 2020 at 08:48:33PM +0800, Hillf Danton wrote: > > - void *addr = vm_map_ram(pages, num, -1, pgprot); > > + void *addr = vmap(pages, num, VM_MAP); > > A merge glitch? > > void *vmap(struct page **pages, unsigned int count, > unsigned long flags, pgprot_t prot) Yes, thanks for the headsup, you were as fast as the build bot :) Fixed now.