Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9358AC433D2
Subject: Re: [PATCH v2 2/5] bus: mhi: core: Make sure to powerdown if
 mhi_sync_power_up fails
To:     hemantk@codeaurora.org
Cc:     manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org
References: <1586278230-29565-1-git-send-email-jhugo@codeaurora.org>
 <1586278230-29565-3-git-send-email-jhugo@codeaurora.org>
 <7249d9608f41e4528c87c2b1c464d615@codeaurora.org>
From:   Jeffrey Hugo <jhugo@codeaurora.org>
Message-ID: <88f9b443-4a1f-918b-297c-203909d8e219@codeaurora.org>
Date:   Wed, 8 Apr 2020 10:19:09 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.2
MIME-Version: 1.0
In-Reply-To: <7249d9608f41e4528c87c2b1c464d615@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 4/7/2020 7:34 PM, hemantk@codeaurora.org wrote:
> On 2020-04-07 09:50, Jeffrey Hugo wrote:
>> Powerdown is necessary if mhi_sync_power_up fails due to a timeout, to
>> clean up the resources.  Otherwise a BUG could be triggered when
>> attempting to clean up MSIs because the IRQ is still active from a
>> request_irq().
>>
>> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
>> ---
>>  drivers/bus/mhi/core/pm.c | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
>> index 3285c9e..fbffc6b 100644
>> --- a/drivers/bus/mhi/core/pm.c
>> +++ b/drivers/bus/mhi/core/pm.c
>> @@ -922,7 +922,11 @@ int mhi_sync_power_up(struct mhi_controller 
>> *mhi_cntrl)
>>                 MHI_PM_IN_ERROR_STATE(mhi_cntrl->pm_state),
>>                 msecs_to_jiffies(mhi_cntrl->timeout_ms));
>>
>> -    return (MHI_IN_MISSION_MODE(mhi_cntrl->ee)) ? 0 : -EIO;
>> +    ret = (MHI_IN_MISSION_MODE(mhi_cntrl->ee)) ? 0 : -EIO;
> 
> Does it make sense to return -ETIMEDOUT instead of -EIO if device fails 
> to move to mission mode?
> Controller can use this info as mhi_async_power_up() would not return 
> -ETIMEDOUT.

It seems sensible to change this to ETIMEDOUT.  I'll queue that up for V3.

> 
>> +    if (ret)
>> +        mhi_power_down(mhi_cntrl, false);
>> +
>> +    return ret;
>>  }
>>  EXPORT_SYMBOL(mhi_sync_power_up);


-- 
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.