Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] of: remove unneeded variable
To:     Ding Xiang <dingxiang@cmss.chinamobile.com>, robh+dt@kernel.org
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1585562702-360-1-git-send-email-dingxiang@cmss.chinamobile.com>
From:   Frank Rowand <frowand.list@gmail.com>
Message-ID: <92c6b7e9-4d55-a5c3-8c7f-5611edeb55c9@gmail.com>
Date:   Wed, 8 Apr 2020 11:00:01 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <1585562702-360-1-git-send-email-dingxiang@cmss.chinamobile.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/30/20 5:05 AM, Ding Xiang wrote:
> rc is unneeded, just return 0.

of: of_detach_node() remove unneeded local return variable

> 
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
> ---
>  drivers/of/dynamic.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
> index 08fd823..fe64430 100644
> --- a/drivers/of/dynamic.c
> +++ b/drivers/of/dynamic.c
> @@ -286,7 +286,6 @@ int of_detach_node(struct device_node *np)
>  {
>  	struct of_reconfig_data rd;
>  	unsigned long flags;
> -	int rc = 0;
>  
>  	memset(&rd, 0, sizeof(rd));
>  	rd.dn = np;
> @@ -301,7 +300,7 @@ int of_detach_node(struct device_node *np)
>  
>  	of_reconfig_notify(OF_RECONFIG_DETACH_NODE, &rd);
>  
> -	return rc;
> +	return 0;
>  }
>  EXPORT_SYMBOL_GPL(of_detach_node);
>  
> 


Reviewed-by: Frank Rowand <frank.rowand@sony.com>