Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <c9c8f4d31a21ba20d030fc197e9c5d6778553521.camel@linux.ibm.com>
Subject: Re: [PATCH v3 1/1] ppc/crash: Reset spinlocks during crash
From:   Leonardo Bras <leonardo@linux.ibm.com>
To:     Michael Ellerman <mpe@ellerman.id.au>,
        Nicholas Piggin <npiggin@gmail.com>,
        Alexios Zavras <alexios.zavras@intel.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Christophe Leroy <christophe.leroy@c-s.fr>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Enrico Weigelt <info@metux.net>,
        Paul Mackerras <paulus@samba.org>, peterz@infradead.org,
        Thomas Gleixner <tglx@linutronix.de>
Cc:     linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Date:   Wed, 08 Apr 2020 13:48:21 -0300
In-Reply-To: <87v9majhh2.fsf@mpe.ellerman.id.au>
References: <20200401000020.590447-1-leonardo@linux.ibm.com>
         <871rp6t9di.fsf@mpe.ellerman.id.au>
         <02e74be19534ab1db2f16a0c89ecb164e380c12a.camel@linux.ibm.com>
         <1585895551.7o9oa0ey62.astroid@bobo.none>
         <fb98f346a4d6a9d689ae64dae33cbd45d2f8b0df.camel@linux.ibm.com>
         <87v9majhh2.fsf@mpe.ellerman.id.au>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-2xsxWow0iUbl6nYPXNaI"
User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-2xsxWow0iUbl6nYPXNaI
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2020-04-08 at 22:21 +1000, Michael Ellerman wrote:
[...]
> > On the other hand, busting the rtas.lock could be dangerous, because
> > it's code we can't control.
> >=20
> > According with LoPAR, for both of these rtas-calls, we have:
> >=20
> > For the PowerPC External Interrupt option: The call must be reentrant
> > to the number of processors on the platform.
> > For the PowerPC External Interrupt option: The argument call buffer for
> > each simultaneous call must be physically unique.
>=20
> Oh well spotted. Where is that in the doc?

In the current LoPAR available on OpenPower Foundation, it's on page
170, '7.3.10.2 ibm,set-xive' and '7.3.10.3 ibm,int-off'.

> > Which I think means this rtas-calls can be done simultaneously.
>=20
> I think so too. I'll read PAPR in the morning and make sure.
>=20
> > Would it mean that busting the rtas.lock for these calls would be safe?
>=20
> What would be better is to make those specific calls not take the global
> RTAS lock to begin with.
>=20
> We should be able to just allocate the rtas_args on the stack, it's only
> ~80 odd bytes. And then we can use rtas_call_unlocked() which doesn't
> take the global lock.

Good idea. I will try getting some work done on this.

Best regards,

--=-2xsxWow0iUbl6nYPXNaI
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEMdeUgIzgjf6YmUyOlQYWtz9SttQFAl6OAFUACgkQlQYWtz9S
ttTHMA//cVNN4TkaS/RG4cF8+zMGbjZkJJVQ4U1PJgiEBcETqk8W6qF5YbAMopj2
RRdQjGnxAlKBheTyTgy1uDVl38bniciIstfwVFOBsdwp43lGfWWVj9XuMrtZD/d+
gS8fJVjEgBrfR5GG/fQvyMUwZVWkZCTFTLnUDb6uAkcT25LC0qBx/j6gybZ2zsHr
M3OYkmc8xUKSbj89ZdPtvHjRzrLvxi2LvOMTRC8yBfYgP6EEhzOJymAxdaY5zwP2
p81SBoWOLAThctMStJu6YZ8xrszkbRW7G7FIRE3DXdLOYGhm8hLF+Zc7xe5Npg30
1IjejGie/7tevB2kTEOjgHugHKGSKnRBkn1BUPhyQdu8xSr02Uy78KlwRxQTzn2Y
R1cWVHtn676LPYG3yZO0fpdyANWeUeOQgGu2R/zV6K9Ou/rmJ+yKvgxm7telw4aU
ENvEF8PeLpK1cTGmS2PY8dJwW/fnX6otFXu0dgvTYLCoIoQruywUnJlL+xQRKmbi
YS7nQTpPRUDM07SKS3zQFL/N1eiBZkjMNdlu539zcZ9kWCjcUWnHCM/M2l77gYTw
/v14vY0ADSTQxCa4PO1mTHsK3gRLagdJtntrC3HO5DbgF68/OrzLbIx6s5+5h4+f
ZMG1lzZlJ6ANGRfke0yhw3RJsvfAIJQNdvlgeI5M4mvbYXVuFUY=
=pR/4
-----END PGP SIGNATURE-----

--=-2xsxWow0iUbl6nYPXNaI--