Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750970AbWB0Jlm (ORCPT ); Mon, 27 Feb 2006 04:41:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750985AbWB0Jlm (ORCPT ); Mon, 27 Feb 2006 04:41:42 -0500 Received: from pproxy.gmail.com ([64.233.166.179]:46381 "EHLO pproxy.gmail.com") by vger.kernel.org with ESMTP id S1750892AbWB0Jll convert rfc822-to-8bit (ORCPT ); Mon, 27 Feb 2006 04:41:41 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=HAOc9WzIiDV1eXrkvHFJKuGE04m1mlLhCTqgSYVWP9Ei1PxBofMWGxBOjbmKJwwgt7AEbROPCMAsmUxSEjHN+N9jitV3XAwU6hzcw4Svhi/Fh4cbQRczmLsjSxiVnLx2dmbXjx1ym6lF0J73RtQcKLOls2LfTl3KunpEFn2UGtE= Message-ID: <9a8748490602270141y67316c66q4be2ce64d9786eb9@mail.gmail.com> Date: Mon, 27 Feb 2006 10:41:40 +0100 From: "Jesper Juhl" To: prasanna@in.ibm.com Subject: Re: [PATCH] kprobes: kprobe_mutex is no longer a semaphore Cc: linux-kernel@vger.kernel.org, "Ananth N Mavinakayanahalli" , "Anil S Keshavamurthy" , "David S. Miller" In-Reply-To: <20060227064258.GB19153@in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Content-Disposition: inline References: <200602251242.46408.jesper.juhl@gmail.com> <20060227064258.GB19153@in.ibm.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1553 Lines: 38 On 2/27/06, Prasanna S Panchamukhi wrote: > On Sat, Feb 25, 2006 at 12:42:46PM +0100, Jesper Juhl wrote: > > > > kprobe_mutex used to be a semaphore it is now a mutex, so calling down/up on > > it is wrong, we should be using mutex_lock/mutex_unlock instead. > > > > gcc was kind enough to warn about this : > > arch/i386/kernel/kprobes.c: In function `arch_remove_kprobe': > > arch/i386/kernel/kprobes.c:135: warning: passing arg 1 of `down' from incompatible pointer type > > arch/i386/kernel/kprobes.c:137: warning: passing arg 1 of `up' from incompatible pointer type > > > > > > Signed-off-by: Jesper Juhl > > > Looks good, this patch depends on the sem2mutex-kprobes.patch in -mm > tree. > http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc4/2.6.16-rc4-mm2/broken-out/sem2mutex-kprobes.patch > > Acked-by : Prasanna S Panchamukhi > Thank you. Are you going to merge it / push it to Andrew or Linus? If not I'll just queue it up with some other patches I have lying around and forward it with those other patches in a week or so. -- Jesper Juhl Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/