Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] dma-debug: fix displaying of dma allocation type
To:     Christoph Hellwig <hch@lst.de>
CC:     Marek Szyprowski <m.szyprowski@samsung.com>,
        Robin Murphy <robin.murphy@arm.com>,
        <iommu@lists.linux-foundation.org>, Sekhar Nori <nsekhar@ti.com>,
        <linux-kernel@vger.kernel.org>
References: <20200408184804.30522-1-grygorii.strashko@ti.com>
 <20200408184958.GA9945@lst.de>
From:   Grygorii Strashko <grygorii.strashko@ti.com>
Message-ID: <ccd0cca4-ca89-3ecd-90d5-66e5e4090f41@ti.com>
Date:   Wed, 8 Apr 2020 22:13:55 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <20200408184958.GA9945@lst.de>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 08/04/2020 21:49, Christoph Hellwig wrote:
> On Wed, Apr 08, 2020 at 09:48:04PM +0300, Grygorii Strashko wrote:
>> The commit 2e05ea5cdc1a ("dma-mapping: implement dma_map_single_attrs using
>> dma_map_page_attrs") removed "dma_debug_page" enum, but missed to update
>> type2name string table. This causes incorrect displaying of dma allocation
>> type. Fix it by removing "page" string from type2name string table.
>>
>> Before (dma_alloc_coherent()):
>> k3-ringacc 4b800000.ringacc: scather-gather idx 2208 P=d1140000 N=d114 D=d1140000 L=40 DMA_BIDIRECTIONAL dma map error check not applicable
>> k3-ringacc 4b800000.ringacc: scather-gather idx 2216 P=d1150000 N=d115 D=d1150000 L=40 DMA_BIDIRECTIONAL dma map error check not applicable
>>
>> After:
>> k3-ringacc 4b800000.ringacc: coherent idx 2208 P=d1140000 N=d114 D=d1140000 L=40 DMA_BIDIRECTIONAL dma map error check not applicable
>> k3-ringacc 4b800000.ringacc: coherent idx 2216 P=d1150000 N=d115 D=d1150000 L=40 DMA_BIDIRECTIONAL dma map error check not applicable
>>
>> Fixes: 2e05ea5cdc1a ("dma-mapping: implement dma_map_single_attrs using dma_map_page_attrs")
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
>>   kernel/dma/debug.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c
>> index 2031ed1ad7fa..09b85ba0c137 100644
>> --- a/kernel/dma/debug.c
>> +++ b/kernel/dma/debug.c
>> @@ -137,7 +137,7 @@ static const char *const maperr2str[] = {
>>   	[MAP_ERR_CHECKED] = "dma map error checked",
>>   };
>>   
>> -static const char *type2name[5] = { "single", "page",
>> +static const char *type2name[5] = { "single",
>>   				    "scather-gather", "coherent",
>>   				    "resource" };
> 
> To make sure this doesn't happen anymore, can you switch to
> named initializers?
> 

Just to clarify.
Do you mean
[dma_debug_coherent] = "coherent",
?


-- 
Best regards,
grygorii