Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200408181406.40389-1-alcooperx@gmail.com> <20200408182557.GR3676135@smile.fi.intel.com>
In-Reply-To: <20200408182557.GR3676135@smile.fi.intel.com>
From:   Alan Cooper <alcooperx@gmail.com>
Date:   Wed, 8 Apr 2020 15:00:05 -0400
Message-ID: <CAOGqxeVZpT2Li86kJSgw7D9hv76Knw8-aTAmq+T03nFf5Q1a4g@mail.gmail.com>
Subject: Re: [PATCH v3 0/4] Add XHCI, EHCI and OHCI support for Broadcom STB SoS's
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     ": Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
        DTML <devicetree@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        USB list <linux-usb@vger.kernel.org>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Rob Herring <robh+dt@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 8, 2020 at 2:25 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Wed, Apr 08, 2020 at 02:14:02PM -0400, Al Cooper wrote:
> > v3 - Addressed all of Andy Shevchenko's review comments for
> >      ehci-brcm.c.
> >    - Fixed the brcm,bcm7445-ehci.yaml dt-bindings document,
> >      dt_binding_check now passes.
> >    - Added the XHCI functionality to xhci-plat.c instead of creating
> >      new brcmstb files, as suggested by Mathias Nyman.
>
> It's nice, but have you heard what Mathias asked / proposed?

I thought that was what I did.

Al

...


>
> > v2 - Addressed Andy Shevchenko's review comments.
> >    - Fixed dt_binding_check error pointed out by Rob Herring.
> >    - Removed pr_info message in ehci_brcm_init as suggested by
> >      Greg Kroah-Hartman.
> >
> > This adds support for the XHCI, EHCI and OHCI host controllers found
> > in Broadcom STB SoC's. These drivers depend on getting access to the
> > new Broadcom STB USB PHY driver through a device-tree phandle and
> > will fail if the driver is not available.
> >
> > Al Cooper (4):
> >   dt-bindings: Add Broadcom STB USB support
> >   usb: xhci: xhci-plat: Add support for Broadcom STB SoC's
> >   usb: ehci: Add new EHCI driver for Broadcom STB SoC's
> >   usb: host: Add ability to build new Broadcom STB USB drivers
> >
> >  .../bindings/usb/brcm,bcm7445-ehci.yaml       |  60 ++++
> >  .../devicetree/bindings/usb/usb-xhci.txt      |   1 +
> >  MAINTAINERS                                   |   8 +
> >  drivers/usb/host/Kconfig                      |  16 +
> >  drivers/usb/host/Makefile                     |  16 +-
> >  drivers/usb/host/ehci-brcm.c                  | 286 ++++++++++++++++++
> >  drivers/usb/host/xhci-plat.c                  |  10 +
> >  7 files changed, 391 insertions(+), 6 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml
> >  create mode 100644 drivers/usb/host/ehci-brcm.c
> >
> > --
> > 2.17.1
> >
>
> --
> With Best Regards,
> Andy Shevchenko
>
>